anchela commented on code in PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/27#discussion_r2253635251
##########
src/main/java/org/apache/sling/auth/oauth_client/impl/SlingUserInfoProcessorImpl.java:
##########
@@ -166,7 +166,7 @@ public SlingUserInfoProcessorImpl(
// Store the Refresh Token on user node
String refreshToken = tokens.accessToken();
if (storeRefreshToken && refreshToken != null) {
-
credentials.setAttribute(OAuthTokenStore.PROPERTY_NAME_ACCESS_TOKEN,
cryptoService.encrypt(refreshToken));
+
credentials.setAttribute(OAuthTokenStore.PROPERTY_NAME_REFRESH_TOKEN,
cryptoService.encrypt(refreshToken));
Review Comment:
in cases where oak login tokens are being created credentials attributes
will be stored in the token node. given that 'refreshToken' is encrypted, i
don't see a huge risk.
but this is something to be aware of.
maybe worth a documentation note....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
