This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-auth-oauth-client.git


The following commit(s) were added to refs/heads/master by this push:
     new c7ea379  chore: remove outdated TODO
c7ea379 is described below

commit c7ea379b2bdf0424852835424fd8a4bde4b2e4da
Author: Robert Munteanu <[email protected]>
AuthorDate: Tue Oct 21 16:53:43 2025 +0200

    chore: remove outdated TODO
    
    Optional.of will gracefully handle a null value
---
 .../java/org/apache/sling/auth/oauth_client/impl/TokenAccessImpl.java    | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/src/main/java/org/apache/sling/auth/oauth_client/impl/TokenAccessImpl.java 
b/src/main/java/org/apache/sling/auth/oauth_client/impl/TokenAccessImpl.java
index c19c805..80b29ce 100644
--- a/src/main/java/org/apache/sling/auth/oauth_client/impl/TokenAccessImpl.java
+++ b/src/main/java/org/apache/sling/auth/oauth_client/impl/TokenAccessImpl.java
@@ -89,7 +89,6 @@ public class TokenAccessImpl implements OAuthTokenAccess {
                 }
                 tokenStore.persistTokens(connection, resolver, newTokens);
 
-                // FIXME: newTokens.accessToken() may return null -> NPE
                 return new 
OAuthTokenResponse(Optional.of(newTokens.accessToken()), connection, request, 
redirectPath);
             }
         }

Reply via email to