This is an automated email from the ASF dual-hosted git repository.
sseifert pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-testing-osgi-mock.git
The following commit(s) were added to refs/heads/master by this push:
new 33bb4c7 Revert switch to org.apache.commons.lang3.Strings to keep
compatibility with older commons-lang 3 versions
33bb4c7 is described below
commit 33bb4c73c305f2b19636cdd24da26ddad374e676
Author: Stefan Seifert <[email protected]>
AuthorDate: Wed Mar 4 09:13:21 2026 +0100
Revert switch to org.apache.commons.lang3.Strings to keep compatibility
with older commons-lang 3 versions
---
.../sling/testing/mock/osgi/MockBundleContext.java | 3 +--
.../sling/testing/mock/osgi/OsgiMetadataUtil.java | 15 +++++++--------
.../sling/testing/mock/osgi/OsgiServiceUtil.java | 19 ++++++++++---------
3 files changed, 18 insertions(+), 19 deletions(-)
diff --git
a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java
b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java
index d64af71..4b10057 100644
---
a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java
+++
b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockBundleContext.java
@@ -41,7 +41,6 @@ import java.util.concurrent.ConcurrentSkipListSet;
import org.apache.commons.io.FileUtils;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.Strings;
import org.apache.felix.framework.FilterImpl;
import org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.DynamicReference;
import org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.Reference;
@@ -529,7 +528,7 @@ class MockBundleContext implements BundleContext {
@Override
public Bundle getBundle(String location) {
- if (Strings.CS.equals(location, Constants.SYSTEM_BUNDLE_LOCATION)) {
+ if (StringUtils.equals(location, Constants.SYSTEM_BUNDLE_LOCATION)) {
return systemBundle;
}
// otherwise return null - no bundle found
diff --git
a/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiMetadataUtil.java
b/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiMetadataUtil.java
index 9801218..10b6683 100644
---
a/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiMetadataUtil.java
+++
b/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiMetadataUtil.java
@@ -48,7 +48,6 @@ import java.util.regex.Pattern;
import org.apache.commons.collections4.BidiMap;
import org.apache.commons.collections4.bidimap.TreeBidiMap;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.Strings;
import org.apache.felix.framework.FilterImpl;
import org.osgi.framework.Constants;
import org.osgi.framework.Filter;
@@ -298,11 +297,11 @@ final class OsgiMetadataUtil {
String name = getAttributeValue(node, "name");
String value = getAttributeValue(node, "value");
String type = getAttributeValue(node, "type");
- if (Strings.CS.equals("Integer", type)) {
+ if (StringUtils.equals("Integer", type)) {
props.put(name, Integer.parseInt(value));
- } else if (Strings.CS.equals("Long", type)) {
+ } else if (StringUtils.equals("Long", type)) {
props.put(name, Long.parseLong(value));
- } else if (Strings.CS.equals("Boolean", type)) {
+ } else if (StringUtils.equals("Boolean", type)) {
props.put(name, Boolean.parseBoolean(value));
} else {
props.put(name, value);
@@ -595,7 +594,7 @@ final class OsgiMetadataUtil {
private static ReferenceCardinality toCardinality(String value) {
for (ReferenceCardinality item : ReferenceCardinality.values()) {
- if (Strings.CS.equals(item.getCardinalityString(), value)) {
+ if (StringUtils.equals(item.getCardinalityString(), value)) {
return item;
}
}
@@ -604,7 +603,7 @@ final class OsgiMetadataUtil {
private static ReferencePolicy toPolicy(String value) {
for (ReferencePolicy item : ReferencePolicy.values()) {
- if (Strings.CI.equals(item.name(), value)) {
+ if (StringUtils.equalsIgnoreCase(item.name(), value)) {
return item;
}
}
@@ -613,7 +612,7 @@ final class OsgiMetadataUtil {
private static ReferencePolicyOption toPolicyOption(String value) {
for (ReferencePolicyOption item : ReferencePolicyOption.values()) {
- if (Strings.CI.equals(item.name(), value)) {
+ if (StringUtils.equalsIgnoreCase(item.name(), value)) {
return item;
}
}
@@ -622,7 +621,7 @@ final class OsgiMetadataUtil {
private static FieldCollectionType toFieldCollectionType(String value)
{
for (FieldCollectionType item : FieldCollectionType.values()) {
- if (Strings.CI.equals(item.name(), value)) {
+ if (StringUtils.equalsIgnoreCase(item.name(), value)) {
return item;
}
}
diff --git
a/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtil.java
b/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtil.java
index 5703fb0..187f58f 100644
--- a/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtil.java
+++ b/core/src/main/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtil.java
@@ -41,7 +41,6 @@ import java.util.function.Predicate;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.Strings;
import org.apache.felix.scr.impl.inject.internal.Annotations;
import org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.DynamicReference;
import org.apache.sling.testing.mock.osgi.OsgiMetadataUtil.FieldCollectionType;
@@ -291,7 +290,7 @@ final class OsgiServiceUtil {
private static Method getMethod(Class clazz, String methodName, Class<?>[]
types) {
Method[] methods = clazz.getDeclaredMethods();
for (Method method : methods) {
- if (Strings.CS.equals(method.getName(), methodName) &&
method.getParameterTypes().length == types.length) {
+ if (StringUtils.equals(method.getName(), methodName) &&
method.getParameterTypes().length == types.length) {
boolean foundMismatch = false;
for (int i = 0; i < types.length; i++) {
if (!((method.getParameterTypes()[i] == types[i])
@@ -311,7 +310,7 @@ final class OsgiServiceUtil {
private static Method getMethodWithAssignableTypes(Class clazz, String
methodName, Class<?>[] types) {
Method[] methods = clazz.getDeclaredMethods();
for (Method method : methods) {
- if (Strings.CS.equals(method.getName(), methodName) &&
method.getParameterTypes().length == types.length) {
+ if (StringUtils.equals(method.getName(), methodName) &&
method.getParameterTypes().length == types.length) {
boolean foundMismatch = false;
for (int i = 0; i < types.length; i++) {
if
(!method.getParameterTypes()[i].isAssignableFrom(types[i])) {
@@ -331,7 +330,7 @@ final class OsgiServiceUtil {
private static Method getMethodWithAnyCombinationArgs(Class clazz, String
methodName, Class<?>[] types) {
Method[] methods = clazz.getDeclaredMethods();
for (Method method : methods) {
- if (Strings.CS.equals(method.getName(), methodName) &&
method.getParameterTypes().length > 1) {
+ if (StringUtils.equals(method.getName(), methodName) &&
method.getParameterTypes().length > 1) {
boolean foundMismatch = false;
for (Class<?> parameterType : method.getParameterTypes()) {
boolean foundAnyMatch = false;
@@ -396,7 +395,8 @@ final class OsgiServiceUtil {
private static Field getField(Class clazz, String fieldName, Class<?>
type) {
Field[] fields = clazz.getDeclaredFields();
for (Field field : fields) {
- if (Strings.CS.equals(field.getName(), fieldName) &&
field.getType().equals(type)) {
+ if (StringUtils.equals(field.getName(), fieldName)
+ && field.getType().equals(type)) {
return field;
}
}
@@ -411,7 +411,8 @@ final class OsgiServiceUtil {
private static Field getFieldWithAssignableType(Class clazz, String
fieldName, Class<?> type) {
Field[] fields = clazz.getDeclaredFields();
for (Field field : fields) {
- if (Strings.CS.equals(field.getName(), fieldName) &&
field.getType().isAssignableFrom(type)) {
+ if (StringUtils.equals(field.getName(), fieldName)
+ && field.getType().isAssignableFrom(type)) {
return field;
}
}
@@ -426,7 +427,7 @@ final class OsgiServiceUtil {
private static Field getCollectionField(Class clazz, String fieldName) {
Field[] fields = clazz.getDeclaredFields();
for (Field field : fields) {
- if (Strings.CS.equals(field.getName(), fieldName) &&
Collection.class.isAssignableFrom(field.getType())) {
+ if (StringUtils.equals(field.getName(), fieldName) &&
Collection.class.isAssignableFrom(field.getType())) {
return field;
}
}
@@ -956,7 +957,7 @@ final class OsgiServiceUtil {
}
if (reference.getPolicy() == ReferencePolicy.DYNAMIC) {
for (String serviceInterface :
registration.getClasses()) {
- if (Strings.CS.equals(serviceInterface,
reference.getInterfaceType())) {
+ if (StringUtils.equals(serviceInterface,
reference.getInterfaceType())) {
references.add(new
ReferenceInfo(existingRegistration, reference));
}
}
@@ -986,7 +987,7 @@ final class OsgiServiceUtil {
if (reference.getPolicy() == ReferencePolicy.STATIC
&& reference.getPolicyOption() ==
ReferencePolicyOption.GREEDY) {
for (String serviceInterface :
registration.getClasses()) {
- if (Strings.CS.equals(serviceInterface,
reference.getInterfaceType())) {
+ if (StringUtils.equals(serviceInterface,
reference.getInterfaceType())) {
references.add(new
ReferenceInfo(existingRegistration, reference));
}
}
