royteeuwen commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/28#issuecomment-4882103181
Thanks for the review @rombert! I've addressed all four points: **1. Jira issue** — created [SLING-13253](https://issues.apache.org/jira/browse/SLING-13253) (New Feature, component *Tooling*). **2. A PR per command/logical change** — this PR is superseded by a stacked series (merge in order): - #29 — `release list`: include open Nexus staging repositories (+ RepositoryService/StagingRepository plumbing) - #30 — `release close-staging` - #31 — `release promote` / `release drop` - #32 — `release update-dist` (embedded SVNKit) - #33 — `release tally-votes`: PMC-aware result email - #34 — `release finalize` + act-by-name + README **3. Move the Skill / collaborate with Magpie** — I'll move the skill to `apache/sling-whiteboard` in a separate PR (it's excluded from the series above). I also cross-referenced the [Magpie release-management skills](https://magpie.apache.org/skills/release-management/readme/): Magpie is ASF-generic, **advisory only** (never executes state changes) and covers **Subversion dist.apache.org only — not Nexus/Maven Central**. The sling-cli is complementary: it *executes*, and owns the Nexus/Maven-Central flow Magpie lacks. So the CLI commands aren't redundant. Where the *skill* overlaps Magpie (vote draft/tally, RC verify, KEYS sync, announce, archive), we should defer to Magpie via Sling-specific config rather than duplicating — I'll raise a follow-up Jira to work that out with the Magpie PMC. **4. svn via a Java API instead of the CLI** — done in #32. Investigation: SVNKit is the only pure-Java SVN library, but its OSGi bundles are published only to the Eclipse P2 update site, not to Maven Central, so I embed it into the sling-cli bundle via bnd (single classloader; only the https/DAV jars embedded, `svn+ssh://` stack marked optional). This removes the need for the `svn`/`svnmucc` binaries. Verified the packaged image resolves the bundle and performs a live DAV listing under the stripped jlink JRE. Closing this in favour of the split PRs above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
