rombert commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-committer-cli/pull/41#discussion_r3757160141
##########
pom.xml:
##########
@@ -318,12 +323,17 @@
<configuration>
<images>
<image>
- <name>apache/sling-cli</name>
+
<name>${docker.image.name}:${docker.image.tag}</name>
<build>
<contextDir>${project.basedir}</contextDir>
<args>
<FEATURE_FILE>target/artifacts/org/apache/sling/${project.artifactId}/${project.version}/${project.artifactId}-${project.version}-app.slingfeature</FEATURE_FILE>
</args>
+ <buildx>
+ <platforms>
+
<platform>${docker.platforms}</platform>
Review Comment:
Ok, not sure what the action here is. Do you want the local build build both
architectures? I don't think that is required and will slow local builds down.
I checked locally and with `mvn --batch-mode install docker:push
-Ddocker.platforms=linux/amd64,linux/arm64` buildx is used in the `build` goal
(and indeed the build is repeated in the install goal but every step is shown
as CACHED for me locally).
Resolving but feel free to suggest something different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
