This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to annotated tag org.apache.sling.scripting.java-2.0.0
in repository 
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-java.git

commit 6b0aef2d74615ca51a044415c29ff84e5eb8d13a
Author: Carsten Ziegeler <[email protected]>
AuthorDate: Mon Jan 18 21:13:47 2010 +0000

    Code cleanup
    
    git-svn-id: 
https://svn.apache.org/repos/asf/sling/trunk/contrib/scripting/java@900561 
13f79535-47bb-0310-9956-ffa450edef68
---
 .../sling/scripting/java/jdt/CompilationUnit.java   | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git 
a/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java 
b/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java
index e491699..cbcae2c 100644
--- a/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java
+++ b/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java
@@ -213,22 +213,25 @@ public class CompilationUnit
      * @see 
org.eclipse.jdt.internal.compiler.env.INameEnvironment#isPackage(char[][], 
char[])
      */
     public boolean isPackage(char[][] parentPackageName, char[] packageName) {
-        StringBuilder result = new StringBuilder();
+        if (Character.isUpperCase(packageName[0])) {
+            return false;
+        }
+        final StringBuilder builder = new StringBuilder();
         if (parentPackageName != null) {
             for (int i = 0; i < parentPackageName.length; i++) {
                 if (i > 0) {
-                    result.append(".");
+                    builder.append(".");
                 }
-                result.append(parentPackageName[i]);
+                builder.append(parentPackageName[i]);
             }
         }
-        String str = new String(packageName);
-        if (Character.isUpperCase(str.charAt(0)) && 
!isPackage(result.toString())) {
-                return false;
+        if (!isPackage(builder.toString())) {
+            return false;
         }
-        result.append(".");
-        result.append(str);
-        return isPackage(result.toString());
+        builder.append(".");
+        builder.append(packageName);
+
+        return isPackage(builder.toString());
     }
 
     /**

-- 
To stop receiving notification emails like this one, please contact
"[email protected]" <[email protected]>.

Reply via email to