This is an automated email from the ASF dual-hosted git repository. rombert pushed a commit to annotated tag org.apache.sling.security-1.0.12 in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-security.git
commit 51371244a22f83a05c40342b9666c0fb9d26a560 Author: Antonio Sanso <[email protected]> AuthorDate: Mon Jul 20 12:05:31 2015 +0000 SLING-4883 - Extend content disposition filter protection to jcr:data * unit tests git-svn-id: https://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/security@1691917 13f79535-47bb-0310-9956-ffa450edef68 --- .../impl/ContentDispositionFilterTest.java | 28 ++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/sling/security/impl/ContentDispositionFilterTest.java b/src/test/java/org/apache/sling/security/impl/ContentDispositionFilterTest.java index 7c989e7..2bde7d4 100644 --- a/src/test/java/org/apache/sling/security/impl/ContentDispositionFilterTest.java +++ b/src/test/java/org/apache/sling/security/impl/ContentDispositionFilterTest.java @@ -20,6 +20,7 @@ import java.util.Dictionary; import java.util.Hashtable; import java.util.Map; import java.util.Set; +import java.util.concurrent.atomic.AtomicInteger; import junitx.util.PrivateAccessor; @@ -291,7 +292,13 @@ public class ContentDispositionFilterTest { } }); PrivateAccessor.invoke(contentDispositionFilter,"activate", new Class[]{ComponentContext.class},new Object[]{ctx}); - final ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response); + + final AtomicInteger counter = new AtomicInteger(); + final ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response) { + public void addHeader(String name, String value) { + counter.incrementAndGet(); + } + }; context.checking(new Expectations() { { @@ -307,7 +314,8 @@ public class ContentDispositionFilterTest { exactly(1).of(response).addHeader("Content-Disposition", "attachment"); } }); - rewriterResponse.setContentType("text/html"); + rewriterResponse.setContentType("text/html"); + Assert.assertEquals(1, counter.intValue()); } @Test @@ -364,7 +372,12 @@ public class ContentDispositionFilterTest { } }); PrivateAccessor.invoke(contentDispositionFilter,"activate", new Class[]{ComponentContext.class},new Object[]{ctx}); - final ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response); + final AtomicInteger counter = new AtomicInteger(); + final ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response) { + public void addHeader(String name, String value) { + counter.incrementAndGet(); + } + }; context.checking(new Expectations() { { @@ -381,6 +394,7 @@ public class ContentDispositionFilterTest { } }); rewriterResponse.setContentType("text/html"); + Assert.assertEquals(1, counter.intValue()); } @Test @@ -401,7 +415,12 @@ public class ContentDispositionFilterTest { } }); PrivateAccessor.invoke(contentDispositionFilter,"activate", new Class[]{ComponentContext.class},new Object[]{ctx}); - ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response); + final AtomicInteger counter = new AtomicInteger(); + final ContentDispositionFilter.RewriterResponse rewriterResponse = contentDispositionFilter. new RewriterResponse(request, response) { + public void addHeader(String name, String value) { + counter.incrementAndGet(); + } + }; context.checking(new Expectations() { { @@ -416,6 +435,7 @@ public class ContentDispositionFilterTest { } }); rewriterResponse.setContentType("text/html"); + //Assert.assertEquals(1, counter.intValue()); } @Test -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
