This is an automated email from the ASF dual-hosted git repository.
chetanm pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-metrics.git
The following commit(s) were added to refs/heads/master by this push:
new e041e99 SLING-6702 - Make MetricsService accessible as easily as a
Logger
e041e99 is described below
commit e041e99219f5441ceee10cea84a4addd764d685c
Author: Chetan Mehrotra <[email protected]>
AuthorDate: Fri Dec 1 16:21:30 2017 +0530
SLING-6702 - Make MetricsService accessible as easily as a Logger
Add a note around handling rewiring of metric service later on
---
.../apache/sling/commons/metrics/internal/MetricsServiceImpl.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git
a/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
b/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
index 5d57ab9..6d5fd08 100644
---
a/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
+++
b/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
@@ -61,6 +61,11 @@ public class MetricsServiceImpl implements MetricsService {
private JmxReporter reporter;
+ /* WARNING: if any OSGi configuration parameters are added to this class
+ * we’ll need to handle the service restart case to prevent service
+ * references retrieved using MetricsServiceFactory from becoming
+ * stale. See discussion in SLING-6702.
+ */
@Activate
private void activate(BundleContext context, Map<String, Object> config) {
enableJMXReporter();
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
