This is an automated email from the ASF dual-hosted git repository.
radu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git
The following commit(s) were added to refs/heads/master by this push:
new 022410d SLING-8328 - The XSSFilterImpl component cannot start on
Jboss 7 deployments
022410d is described below
commit 022410d1cc151a94a887c9c1a76226420c24472b
Author: Radu Cotescu <[email protected]>
AuthorDate: Wed Mar 27 14:51:46 2019 +0100
SLING-8328 - The XSSFilterImpl component cannot start on Jboss 7 deployments
* added notes in JavaDoc about the need to embed both FactoryFinders
* corrected JavaDoc generation
---
pom.xml | 11 +++++++++++
src/main/java/javax/xml/parsers/FactoryFinder.java | 21 ++++++++++++---------
.../java/javax/xml/transform/FactoryFinder.java | 15 ++++++++++++---
3 files changed, 35 insertions(+), 12 deletions(-)
diff --git a/pom.xml b/pom.xml
index a36d40a..e7fde32 100644
--- a/pom.xml
+++ b/pom.xml
@@ -125,6 +125,17 @@
</instructions>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <!-- No javadocs -->
+ <excludePackageNames>
+ javax.xml.*,
+ *.impl.*
+ </excludePackageNames>
+ </configuration>
+ </plugin>
</plugins>
</build>
diff --git a/src/main/java/javax/xml/parsers/FactoryFinder.java
b/src/main/java/javax/xml/parsers/FactoryFinder.java
index 8192e61..1ff4f95 100644
--- a/src/main/java/javax/xml/parsers/FactoryFinder.java
+++ b/src/main/java/javax/xml/parsers/FactoryFinder.java
@@ -19,23 +19,26 @@
package javax.xml.parsers;
-import java.io.BufferedReader;
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.util.Properties;
-
/**
- * This class is duplicated for each JAXP subpackage so keep it in
+ * <p>This class is duplicated for each JAXP subpackage so keep it in
* sync. It is package private.
*
- * This code is designed to implement the JAXP 1.1 spec pluggability
+ * <p>This code is designed to implement the JAXP 1.1 spec pluggability
* feature and is designed to run on JDK version 1.1 and later including
* JVMs that perform early linking like the Microsoft JVM in IE 5. Note
* however that it must be compiled on a JDK version 1.2 or later system
* since it calls Thread#getContextClassLoader(). The code also runs both
* as part of an unbundled jar file and when bundled as part of the JDK.
+ *
+ * <p><strong>NOTE</strong>:
+ * <p>This class is included in order to make sure that all {@code
javax.xml.parsers} factories are the ones embedded by the bundle
+ * and not the ones provided by the underlying JVM or platform.
+ *
+ * <p>For more details check the following issues:
+ * <ol>
+ * <li>https://issues.apache.org/jira/browse/SLING-8321</li>
+ * <li>https://issues.apache.org/jira/browse/SLING-8328</li>
+ * </ol>
*/
final class FactoryFinder {
diff --git a/src/main/java/javax/xml/transform/FactoryFinder.java
b/src/main/java/javax/xml/transform/FactoryFinder.java
index db11290..5b0ee1d 100644
--- a/src/main/java/javax/xml/transform/FactoryFinder.java
+++ b/src/main/java/javax/xml/transform/FactoryFinder.java
@@ -19,17 +19,26 @@
package javax.xml.transform;
-
/**
- * This class is duplicated for each JAXP subpackage so keep it in
+ * <p>This class is duplicated for each JAXP subpackage so keep it in
* sync. It is package private.
*
- * This code is designed to implement the JAXP 1.1 spec pluggability
+ * <p>This code is designed to implement the JAXP 1.1 spec pluggability
* feature and is designed to run on JDK version 1.1 and later including
* JVMs that perform early linking like the Microsoft JVM in IE 5. Note
* however that it must be compiled on a JDK version 1.2 or later system
* since it calls Thread#getContextClassLoader(). The code also runs both
* as part of an unbundled jar file and when bundled as part of the JDK.
+ *
+ * <p><strong>NOTE</strong>:
+ * <p>This class is included in order to make sure that all {@code
javax.xml.parsers} factories are the ones embedded by the bundle
+ * and not the ones provided by the underlying JVM or platform.
+ *
+ * <p>For more details check the following issues:
+ * <ol>
+ * <li>https://issues.apache.org/jira/browse/SLING-8321</li>
+ * <li>https://issues.apache.org/jira/browse/SLING-8328</li>
+ * </ol>
*/
final class FactoryFinder {