[sling-whiteboard] branch master updated: [api-region] just make sure added (invalid) API produces the expected result

[simonetripodi]

This is an automated email from the ASF dual-hosted git repository.

simonetripodi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-whiteboard.git


The following commit(s) were added to refs/heads/master by this push:
     new ae6e019  [api-region] just make sure added (invalid) API produces the 
expected result
ae6e019 is described below

commit ae6e01935840cbccd2945d3c4b58eb15c534042c
Author: stripodi <stripodi@192.168.1.111>
AuthorDate: Thu Apr 4 16:17:37 2019 +0200

    [api-region] just make sure added (invalid) API produces the expected
    result
---
 .../org/apache/sling/feature/apiregions/ApiRegionTest.java  | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git 
a/feature-api-regions/src/test/java/org/apache/sling/feature/apiregions/ApiRegionTest.java
 
b/feature-api-regions/src/test/java/org/apache/sling/feature/apiregions/ApiRegionTest.java
index 06ff425..948aa42 100644
--- 
a/feature-api-regions/src/test/java/org/apache/sling/feature/apiregions/ApiRegionTest.java
+++ 
b/feature-api-regions/src/test/java/org/apache/sling/feature/apiregions/ApiRegionTest.java
@@ -50,15 +50,22 @@ public class ApiRegionTest {
 
     private void ingnoreApi(String api) {
         ApiRegion testRegion = new ApiRegion(getClass().getName(), null);
-        testRegion.addApi(api);
+        assertFalse(testRegion.addApi(api));
         assertFalse(testRegion.contains(api));
     }
 
     @Test
     public void inheritanceCheck() {
         ApiRegion granpa = new ApiRegion("granpa", null);
+        assertTrue(granpa.addApi("org.apache.sling.feature.apiregions"));
+
         ApiRegion father = new ApiRegion("father", granpa);
+        assertTrue(father.addApi("org.apache.sling.feature.apiregions.io"));
+        assertFalse(father.addApi("org.apache.sling.feature.apiregions")); // 
inherited by granpa
+
         ApiRegion child = new ApiRegion("child", father);
+        assertFalse(child.addApi("org.apache.sling.feature.apiregions.io")); 
// inherited by father
+        assertFalse(child.addApi("org.apache.sling.feature.apiregions")); // 
inherited by granpa
 
         assertSame(father, child.getParent());
         assertSame(granpa, father.getParent());
@@ -77,8 +84,8 @@ public class ApiRegionTest {
         child.addApi("org.apache.sling.feature.apiregions.io.json");
 
         
assertTrue(child.contains("org.apache.sling.feature.apiregions.io.json"));
-        assertTrue(child.contains("org.apache.sling.feature.apiregions.io")); 
// inherited
-        assertTrue(child.contains("org.apache.sling.feature.apiregions")); // 
inherited-inherited
+        assertTrue(child.contains("org.apache.sling.feature.apiregions.io")); 
// inherited by father
+        assertTrue(child.contains("org.apache.sling.feature.apiregions")); // 
inherited by granpa
     }
 
     @Test