cschneider commented on a change in pull request #5: Sling 8414
URL:
https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/pull/5#discussion_r283107855
##########
File path:
src/main/java/org/apache/sling/distribution/journal/kafka/KafkaEndpoint.java
##########
@@ -36,4 +37,17 @@
@AttributeDefinition(name = "Kafka Default API Timeout",
description = "Kafka Default API Timeout in ms.")
int kafkaDefaultApiTimeout() default 60000;
+
+ @AttributeDefinition(name = "Security protocol",
+ description = "e.g. SASL_SSL")
+ SecurityProtocol securityProtocol() default SecurityProtocol.PLAINTEXT;
+
+ @AttributeDefinition(name = "Sasl mechanism",
+ description = "e.g. PLAIN")
+ String saslMechanism() default "";
Review comment:
I am not sure what happens if I set this if I do not want to use sasl at
all. If you know it will not affect the plain kafka case then I will change it
to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
