This is an automated email from the ASF dual-hosted git repository.
dklco pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-app-cms.git
The following commit(s) were added to refs/heads/master by this push:
new 11b9802 Fixing some SonarQube false flag warnings
new 4e308ce Merge branch 'master' of
github.com:apache/sling-org-apache-sling-app-cms
11b9802 is described below
commit 11b9802f363a06789ad68e36660dd6050cde09b8
Author: Dan Klco <[email protected]>
AuthorDate: Tue Jun 4 10:44:05 2019 -0400
Fixing some SonarQube false flag warnings
---
.../org/apache/sling/cms/core/insights/impl/InsightsWebConsole.java | 4 +---
.../cms/core/internal/operations/PropertyHintNodeNameGenerator.java | 2 ++
.../sling/cms/transformer/internal/TransformerWebConsole.java | 6 ++----
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git
a/core/src/main/java/org/apache/sling/cms/core/insights/impl/InsightsWebConsole.java
b/core/src/main/java/org/apache/sling/cms/core/insights/impl/InsightsWebConsole.java
index 773318e..e2895a1 100644
---
a/core/src/main/java/org/apache/sling/cms/core/insights/impl/InsightsWebConsole.java
+++
b/core/src/main/java/org/apache/sling/cms/core/insights/impl/InsightsWebConsole.java
@@ -45,13 +45,11 @@ import org.osgi.service.component.annotations.Reference;
WebConsoleConstants.PLUGIN_CATEGORY + "=Status" }, service = {
Servlet.class })
public class InsightsWebConsole extends AbstractWebConsolePlugin {
- /**
- *
- */
private static final long serialVersionUID = 4819043498961127418L;
public static final String CONSOLE_LABEL = "slingcms-insights";
public static final String CONSOLE_TITLE = "Sling CMS Insights";
+ @SuppressWarnings("squid:S2078") // ignore since this field is is injected
by OSGi
@Reference
private InsightFactory insightFactory;
diff --git
a/core/src/main/java/org/apache/sling/cms/core/internal/operations/PropertyHintNodeNameGenerator.java
b/core/src/main/java/org/apache/sling/cms/core/internal/operations/PropertyHintNodeNameGenerator.java
index 02c8a35..06d9770 100644
---
a/core/src/main/java/org/apache/sling/cms/core/internal/operations/PropertyHintNodeNameGenerator.java
+++
b/core/src/main/java/org/apache/sling/cms/core/internal/operations/PropertyHintNodeNameGenerator.java
@@ -41,9 +41,11 @@ public class PropertyHintNodeNameGenerator implements
NodeNameGenerator {
public @interface Config {
+ @SuppressWarnings("squid:S00100") // ignore we have to support the old
property format
@AttributeDefinition(name = "%allowed.chars.name", description =
"%allowed.chars.description")
String allowed_chars() default
"abcdefghijklmnopqrstuvwxyz0123456789_-";
+ @SuppressWarnings("squid:S00100") // ignore we have to support the old
property format
@AttributeDefinition(name = "%replacement.char.name", description =
"%replacement.char.description")
String replacement_char() default "-";
}
diff --git
a/transformer/src/main/java/org/apache/sling/cms/transformer/internal/TransformerWebConsole.java
b/transformer/src/main/java/org/apache/sling/cms/transformer/internal/TransformerWebConsole.java
index 597897f..ca9706d 100644
---
a/transformer/src/main/java/org/apache/sling/cms/transformer/internal/TransformerWebConsole.java
+++
b/transformer/src/main/java/org/apache/sling/cms/transformer/internal/TransformerWebConsole.java
@@ -49,15 +49,13 @@ import com.google.common.collect.Lists;
WebConsoleConstants.PLUGIN_CATEGORY + "=Status" }, service = {
Servlet.class })
public class TransformerWebConsole extends AbstractWebConsolePlugin {
- /**
- *
- */
private static final long serialVersionUID = 4819043498961127418L;
public static final String CONSOLE_LABEL = "slingcms-transformer";
public static final String CONSOLE_TITLE = "Sling CMS Transformer";
+ @SuppressWarnings("squid:S2078") // ignore since this field is is injected
by OSGi
@Reference
- private FileThumbnailTransformer fileThumbnailTransformer;
+ private transient FileThumbnailTransformer fileThumbnailTransformer;
@Override
public String getTitle() {
