cschneider commented on a change in pull request #8: SLING-8531 - Exponential
backoff for retries
URL:
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/8#discussion_r301960522
##########
File path:
src/main/java/org/apache/sling/distribution/journal/impl/shared/JournalAvailableChecker.java
##########
@@ -18,40 +18,40 @@
*/
package org.apache.sling.distribution.journal.impl.shared;
-import javax.annotation.ParametersAreNonnullByDefault;
-
import static java.util.Objects.requireNonNull;
-import static
org.apache.sling.commons.scheduler.Scheduler.PROPERTY_SCHEDULER_CONCURRENT;
-import static
org.apache.sling.commons.scheduler.Scheduler.PROPERTY_SCHEDULER_IMMEDIATE;
-import static
org.apache.sling.commons.scheduler.Scheduler.PROPERTY_SCHEDULER_PERIOD;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.sling.distribution.journal.ExceptionEventSender;
+import org.apache.sling.distribution.journal.JournalAvailable;
+import org.apache.sling.distribution.journal.MessagingProvider;
+import
org.apache.sling.distribution.journal.impl.shared.DistributionMetricsService.GaugeService;
import org.osgi.framework.BundleContext;
import org.osgi.framework.ServiceRegistration;
import org.osgi.service.component.annotations.Activate;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Deactivate;
import org.osgi.service.component.annotations.Reference;
+import org.osgi.service.event.Event;
+import org.osgi.service.event.EventConstants;
+import org.osgi.service.event.EventHandler;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.apache.sling.distribution.journal.MessagingProvider;
-import
org.apache.sling.distribution.journal.impl.shared.DistributionMetricsService.GaugeService;
-import org.apache.sling.distribution.journal.JournalAvailable;
-
-@Component(
- service = {Runnable.class},
- immediate = true,
- property = {
- PROPERTY_SCHEDULER_IMMEDIATE + ":Boolean=true",
- PROPERTY_SCHEDULER_CONCURRENT + ":Boolean=false",
- PROPERTY_SCHEDULER_PERIOD + ":Long=" + 90 // 90 seconds
- }
+@Component(
+ property = EventConstants.EVENT_TOPIC + "=" +
ExceptionEventSender.ERROR_TOPIC
)
-@ParametersAreNonnullByDefault
-public class JournalAvailableChecker implements JournalAvailable, Runnable {
+public class JournalAvailableChecker implements JournalAvailable, EventHandler
{
+
+ private static final int MAX_RETGRY_DELAY_MS = 10000;
Review comment:
Will switch to startDelay=1 second and maxDelay=5 minutes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
