tmaret commented on a change in pull request #24: SLING-9075 - Support multiple
agents with one StagingPrecondition
URL:
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/24#discussion_r380646199
##########
File path:
src/main/java/org/apache/sling/distribution/journal/impl/subscriber/PackageStatusWatcher.java
##########
@@ -19,33 +19,29 @@
package org.apache.sling.distribution.journal.impl.subscriber;
-import org.apache.sling.distribution.journal.impl.shared.Topics;
-import org.apache.sling.distribution.journal.messages.Messages;
-import
org.apache.sling.distribution.journal.messages.Messages.PackageStatusMessage;
-import org.apache.sling.distribution.journal.FullMessage;
-import org.apache.sling.distribution.journal.MessageInfo;
-import org.apache.sling.distribution.journal.MessagingProvider;
-import org.apache.sling.distribution.journal.Reset;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.apache.sling.distribution.journal.HandlerAdapter.create;
import java.io.Closeable;
import java.io.IOException;
-import java.util.NavigableMap;
-import java.util.concurrent.ConcurrentSkipListMap;
+import java.util.HashMap;
+import java.util.Map;
-import static org.apache.sling.distribution.journal.HandlerAdapter.create;
+import org.apache.sling.distribution.journal.MessageInfo;
+import org.apache.sling.distribution.journal.MessagingProvider;
+import org.apache.sling.distribution.journal.Reset;
+import org.apache.sling.distribution.journal.impl.shared.Topics;
+import org.apache.sling.distribution.journal.messages.Messages;
+import
org.apache.sling.distribution.journal.messages.Messages.PackageStatusMessage;
+import
org.apache.sling.distribution.journal.messages.Messages.PackageStatusMessage.Status;
public class PackageStatusWatcher implements Closeable {
- private static final Logger LOG =
LoggerFactory.getLogger(PackageStatusWatcher.class);
-
private final Closeable poller;
- private final String subAgentName;
- private final NavigableMap<Long, FullMessage<PackageStatusMessage>> cache
= new ConcurrentSkipListMap<>();
+
+ // subAgentName -> pkgOffset -> Status
+ private final Map<String, Map<Long, Status>> pkgStatusPerSubAgent = new
HashMap<>();
Review comment:
It seems that `pkgStatusPerSubAgent` should be a `ConcurrentMap` as
`getAgentStatus` (get or set) is invoked from multiple threads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
