This is an automated email from the ASF dual-hosted git repository.

enorman pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-jackrabbit-accessmanager.git


The following commit(s) were added to refs/heads/master by this push:
     new 9daf99e  SLING-9608 Cleanup javadoc errors
9daf99e is described below

commit 9daf99ecd4e49665b3906869e2dc8b83e2ab09b5
Author: Eric Norman <[email protected]>
AuthorDate: Sun Jul 26 15:44:09 2020 -0700

    SLING-9608 Cleanup javadoc errors
---
 .../jcr/jackrabbit/accessmanager/DeleteAces.java   |  2 +-
 .../sling/jcr/jackrabbit/accessmanager/GetAcl.java |  2 +-
 .../jackrabbit/accessmanager/GetEffectiveAcl.java  |  2 +-
 .../jcr/jackrabbit/accessmanager/ModifyAce.java    | 80 ++++++++++++----------
 .../jackrabbit/accessmanager/PrivilegesInfo.java   | 24 +++----
 .../post/AbstractAccessPostServlet.java            | 25 +++++--
 .../accessmanager/post/DeleteAcesServlet.java      |  3 +-
 .../accessmanager/post/GetAclServlet.java          |  5 +-
 .../accessmanager/post/GetEffectiveAclServlet.java |  5 +-
 .../accessmanager/post/ModifyAceServlet.java       |  5 +-
 10 files changed, 85 insertions(+), 68 deletions(-)

diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/DeleteAces.java 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/DeleteAces.java
index 4ff111c..2c6102c 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/DeleteAces.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/DeleteAces.java
@@ -36,7 +36,7 @@ public interface DeleteAces {
         * @param jcrSession the JCR session of the user updating the user
         * @param resourcePath The path of the resource to update the ACL for 
(required)
         * @param principalNamesToDelete An array of ace principal names to 
delete.. (required)
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors applying the changes 
         */
        void deleteAces(Session jcrSession,
                                                        String resourcePath,
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetAcl.java 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetAcl.java
index be9d415..14b00f3 100644
--- a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetAcl.java
+++ b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetAcl.java
@@ -37,7 +37,7 @@ public interface GetAcl {
         * @param jcrSession the JCR session of the user updating the user
         * @param resourcePath The path of the resource to get the ACL for 
(required)
      * @return the ACL as a JSON object 
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        JsonObject getAcl(Session jcrSession,
                                                        String resourcePath
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetEffectiveAcl.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetEffectiveAcl.java
index c192df0..767ef46 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetEffectiveAcl.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/GetEffectiveAcl.java
@@ -37,7 +37,7 @@ public interface GetEffectiveAcl {
         * @param jcrSession the JCR session of the user updating the user
         * @param resourcePath The path of the resource to get the ACL for 
(required)
      * @return the ACL as a JSON object 
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        JsonObject getEffectiveAcl(Session jcrSession,
                                                        String resourcePath
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/ModifyAce.java 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/ModifyAce.java
index f096763..ffcfdd1 100644
--- a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/ModifyAce.java
+++ b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/ModifyAce.java
@@ -47,16 +47,18 @@ public interface ModifyAce {
         * @param principalId The name of the user/group to provision (required)
         * @param privileges Map of privileges to apply. (optional)
      * @param order where the access control entry should go in the list.
-     *         Value should be one of these:
-     *         <table>
-     *          <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
-     *                         <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
-        *                      <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
-        *                      <tr><td>before xyz</td><td>Place the target ACE 
immediately before the sibling whose name is xyz</td></tr>
-        *                      <tr><td>after xyz</td><td>Place the target ACE 
immediately after the sibling whose name is xyz</td></tr>
-        *                      <tr><td>numeric</td><td>Place the target ACE at 
the specified numeric index</td></tr>
+     *         <table style='margin-left: 30px;' border="1">
+     *          <caption>The value should be one of these:</caption>
+     *          <tbody>
+     *            <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
+     *                           <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
+        *                        <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
+        *                        <tr><td>before xyz</td><td>Place the target 
ACE immediately before the sibling whose name is xyz</td></tr>
+        *                        <tr><td>after xyz</td><td>Place the target 
ACE immediately after the sibling whose name is xyz</td></tr>
+        *                        <tr><td>numeric</td><td>Place the target ACE 
at the specified numeric index</td></tr>
+     *          </tbody>
         *         </table>
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors applying the changes 
         */
        void modifyAce(Session jcrSession,
                                                        String resourcePath,
@@ -74,17 +76,19 @@ public interface ModifyAce {
         * @param principalId The name of the user/group to provision (required)
         * @param privileges Map of privileges to apply. (optional)
      * @param order where the access control entry should go in the list.
-     *         Value should be one of these:
-     *         <table>
-     *          <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
-     *                         <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
-        *                      <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
-        *                      <tr><td>before xyz</td><td>Place the target ACE 
immediately before the sibling whose name is xyz</td></tr>
-        *                      <tr><td>after xyz</td><td>Place the target ACE 
immediately after the sibling whose name is xyz</td></tr>
-        *                      <tr><td>numeric</td><td>Place the target ACE at 
the specified numeric index</td></tr>
+     *         <table style='margin-left: 30px;' border="1">
+     *          <caption>The value should be one of these:</caption>
+     *          <tbody>
+     *            <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
+     *                           <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
+        *                        <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
+        *                        <tr><td>before xyz</td><td>Place the target 
ACE immediately before the sibling whose name is xyz</td></tr>
+        *                        <tr><td>after xyz</td><td>Place the target 
ACE immediately after the sibling whose name is xyz</td></tr>
+        *                        <tr><td>numeric</td><td>Place the target ACE 
at the specified numeric index</td></tr>
+     *          </tbody>
         *         </table>
         * @param autoSave true to automatically save changes to the JCR 
session, false otherwise
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors applying the changes 
         */
        default void modifyAce(Session jcrSession,
                                                        String resourcePath,
@@ -108,19 +112,21 @@ public interface ModifyAce {
         * @param principalId The name of the user/group to provision (required)
         * @param privileges Map of privileges to apply. (optional)
      * @param order where the access control entry should go in the list.
-     *         Value should be one of these:
-     *         <table>
-     *          <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
-     *                         <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
-        *                      <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
-        *                      <tr><td>before xyz</td><td>Place the target ACE 
immediately before the sibling whose name is xyz</td></tr>
-        *                      <tr><td>after xyz</td><td>Place the target ACE 
immediately after the sibling whose name is xyz</td></tr>
-        *                      <tr><td>numeric</td><td>Place the target ACE at 
the specified numeric index</td></tr>
+     *         <table style='margin-left: 30px;' border="1">
+     *          <caption>The value should be one of these:</caption>
+     *          <tbody>
+     *            <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
+     *                           <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
+        *                        <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
+        *                        <tr><td>before xyz</td><td>Place the target 
ACE immediately before the sibling whose name is xyz</td></tr>
+        *                        <tr><td>after xyz</td><td>Place the target 
ACE immediately after the sibling whose name is xyz</td></tr>
+        *                        <tr><td>numeric</td><td>Place the target ACE 
at the specified numeric index</td></tr>
+     *          </tbody>
         *         </table>
         * @param restrictions Map of single-value restrictions to apply. 
(optional)
         * @param mvRestrictions Map of multi-value restrictions to apply. 
(optional)
         * @param removeRestrictionNames Set of existing restriction names to 
remove (optional)
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors applying the changes 
         */
        default void modifyAce(Session jcrSession,
                                                        String resourcePath,
@@ -145,20 +151,22 @@ public interface ModifyAce {
         * @param principalId The name of the user/group to provision (required)
         * @param privileges Map of privileges to apply. (optional)
      * @param order where the access control entry should go in the list.
-     *         Value should be one of these:
-     *         <table>
-     *          <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
-     *                         <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
-        *                      <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
-        *                      <tr><td>before xyz</td><td>Place the target ACE 
immediately before the sibling whose name is xyz</td></tr>
-        *                      <tr><td>after xyz</td><td>Place the target ACE 
immediately after the sibling whose name is xyz</td></tr>
-        *                      <tr><td>numeric</td><td>Place the target ACE at 
the specified numeric index</td></tr>
+     *         <table style='margin-left: 30px;' border="1">
+     *          <caption>The value should be one of these:</caption>
+     *          <tbody>
+     *            <tr><td>null</td><td>If the ACE for the principal doesn't 
exist add at the end, otherwise leave the ACE at it's current 
position.</td></tr>
+     *                           <tr><td>first</td><td>Place the target ACE as 
the first amongst its siblings</td></tr>
+        *                        <tr><td>last</td><td>Place the target ACE as 
the last amongst its siblings</td></tr>
+        *                        <tr><td>before xyz</td><td>Place the target 
ACE immediately before the sibling whose name is xyz</td></tr>
+        *                        <tr><td>after xyz</td><td>Place the target 
ACE immediately after the sibling whose name is xyz</td></tr>
+        *                        <tr><td>numeric</td><td>Place the target ACE 
at the specified numeric index</td></tr>
+     *          </tbody>
         *         </table>
         * @param restrictions Map of single-value restrictions to apply. 
(optional)
         * @param mvRestrictions Map of multi-value restrictions to apply. 
(optional)
         * @param removeRestrictionNames Set of existing restriction names to 
remove (optional)
         * @param autoSave true to automatically save changes to the JCR 
session, false otherwise
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors applying the changes 
         */
        default void modifyAce(Session jcrSession,
                                                        String resourcePath,
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/PrivilegesInfo.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/PrivilegesInfo.java
index b4f7744..1866ae0 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/PrivilegesInfo.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/PrivilegesInfo.java
@@ -52,7 +52,7 @@ public class PrivilegesInfo {
         * 
         * @param node the node to check
         * @return array of Privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Privilege [] getSupportedPrivileges(Node node) throws 
RepositoryException {
                return getSupportedPrivileges(node.getSession(), 
node.getPath());
@@ -64,7 +64,7 @@ public class PrivilegesInfo {
         * @param session the session for the current user
         * @param absPath the path to get the privileges for
         * @return array of Privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Privilege [] getSupportedPrivileges(Session session, String 
absPath) throws RepositoryException {
                AccessControlManager accessControlManager = 
AccessControlUtil.getAccessControlManager(session);
@@ -141,7 +141,7 @@ public class PrivilegesInfo {
         * 
         * @param node the node to get the access rights for
         * @return map of access rights.  Key is the user/group principal, 
value contains the granted/denied privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<Principal, AccessRights> getDeclaredAccessRights(Node node) 
throws RepositoryException {
                Map<Principal, AccessRights> accessRights = 
getDeclaredAccessRights(node.getSession(), node.getPath());
@@ -155,7 +155,7 @@ public class PrivilegesInfo {
         * @param session the current user session.
         * @param absPath the path of the resource to get the access rights for
         * @return map of access rights.  Key is the user/group principal, 
value contains the granted/denied privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<Principal, AccessRights> getDeclaredAccessRights(Session 
session, String absPath) throws RepositoryException {
                Map<Principal, AccessRights> accessMap = new 
LinkedHashMap<Principal, AccessRights>();
@@ -203,7 +203,7 @@ public class PrivilegesInfo {
         * @param node the JCR node to retrieve the access rights for
         * @param principalId the principalId to get the access rights for
         * @return access rights for the specified principal
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public AccessRights getDeclaredAccessRightsForPrincipal(Node node, 
String principalId) throws RepositoryException {
                return getDeclaredAccessRightsForPrincipal(node.getSession(), 
node.getPath(), principalId);
@@ -217,7 +217,7 @@ public class PrivilegesInfo {
         * @param absPath the path of the resource to retrieve the rights for
         * @param principalId the principalId to get the access rights for
         * @return access rights for the specified principal
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public AccessRights getDeclaredAccessRightsForPrincipal(Session 
session, String absPath, String principalId) throws RepositoryException {
                AccessRights rights = new AccessRights();
@@ -250,7 +250,7 @@ public class PrivilegesInfo {
         * @param node the node to inspect
         * @param principalId the principalId to get the access rights for
         * @return map of restrictions (key is restriction name, value is Value 
or Value[])
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<String, Object> getDeclaredRestrictionsForPrincipal(Node 
node, String principalId) throws RepositoryException {
                return getDeclaredRestrictionsForPrincipal(node.getSession(), 
node.getPath(), principalId);
@@ -263,7 +263,7 @@ public class PrivilegesInfo {
         * @param absPath the path to get the privileges for
         * @param principalId the principalId to get the access rights for
         * @return map of restrictions (key is restriction name, value is Value 
or Value[])
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<String, Object> getDeclaredRestrictionsForPrincipal(Session 
session, String absPath, String principalId) throws RepositoryException {
                Map<String, Object> restrictions = new LinkedHashMap<>();
@@ -305,7 +305,7 @@ public class PrivilegesInfo {
         * 
         * @param node the node to get the access rights for
         * @return map of access rights.  Key is the user/group principal, 
value contains the granted/denied privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<Principal, AccessRights> getEffectiveAccessRights(Node node) 
throws RepositoryException {
                Map<Principal, AccessRights> accessRights = 
getEffectiveAccessRights(node.getSession(), node.getPath());
@@ -319,7 +319,7 @@ public class PrivilegesInfo {
         * @param session the current user session.
         * @param absPath the path of the resource to get the access rights for
         * @return map of access rights.  Key is the user/group principal, 
value contains the granted/denied privileges
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public Map<Principal, AccessRights> getEffectiveAccessRights(Session 
session, String absPath) throws RepositoryException {
                Map<Principal, AccessRights> accessMap = new 
LinkedHashMap<Principal, AccessRights>();
@@ -367,7 +367,7 @@ public class PrivilegesInfo {
         * @param node the JCR node to retrieve the access rights for
         * @param principalId the principalId to get the access rights for
         * @return access rights for the specified principal
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public AccessRights getEffectiveAccessRightsForPrincipal(Node node, 
String principalId) throws RepositoryException {
                return getEffectiveAccessRightsForPrincipal(node.getSession(), 
node.getPath(), principalId);
@@ -381,7 +381,7 @@ public class PrivilegesInfo {
         * @param absPath the path of the resource to retrieve the rights for
         * @param principalId the principalId to get the access rights for
         * @return access rights for the specified principal
-        * @throws RepositoryException
+        * @throws RepositoryException if any errors reading the information
         */
        public AccessRights getEffectiveAccessRightsForPrincipal(Session 
session, String absPath, String principalId) throws RepositoryException {
                AccessRights rights = new AccessRights();
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/AbstractAccessPostServlet.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/AbstractAccessPostServlet.java
index 63d9eae..b41171f 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/AbstractAccessPostServlet.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/AbstractAccessPostServlet.java
@@ -153,11 +153,11 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
     /**
      * Creates an instance of a HtmlResponse.
      * @param req The request being serviced
-     * @return a {@link 
org.apache.sling.servlets.post.impl.helper.JSONResponse} if any of these 
conditions are true:
+     * @return a {@link org.apache.sling.servlets.post.JSONResponse} if any of 
these conditions are true:
      * <ul>
      *   <li>the response content type is application/json
      * </ul>
-     * or a {@link org.apache.sling.api.servlets.HtmlResponse} otherwise
+     * or a {@link org.apache.sling.servlets.post.HtmlResponse} otherwise
      * @deprecated use {@link #createPostResponse(SlingHttpServletRequest)} 
instead
      */
        @Deprecated
@@ -168,7 +168,7 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
     /**
      * Creates an instance of a PostResponse.
      * @param req The request being serviced
-     * @return a {@link 
org.apache.sling.servlets.post.impl.helper.JSONResponse} if any of these 
conditions are true:
+     * @return a {@link org.apache.sling.servlets.post.JSONResponse} if any of 
these conditions are true:
      * <ul>
      *   <li> the request has an <code>Accept</code> header of 
<code>application/json</code></li>
      *   <li>the request is a JSON POST request (see SLING-1172)</li>
@@ -212,7 +212,8 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
         *
         * @param request the sling http request to process
         * @param response the response
-        * @param changes
+     * @param changes the changes to report
+        * @throws RepositoryException if any errors applying the changes 
         * 
         * @deprecated use {@link #handleOperation(SlingHttpServletRequest, 
PostResponse, List)} instead
         */
@@ -227,7 +228,8 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
         *
         * @param request the sling http request to process
         * @param response the response
-        * @param changes
+     * @param changes the changes to report
+        * @throws RepositoryException if any errors applying the changes 
         */
        abstract protected void handleOperation(SlingHttpServletRequest request,
                        PostResponse response, List<Modification> changes) 
throws RepositoryException;
@@ -236,6 +238,7 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
     /**
      * compute redirect URL (SLING-126)
      *
+        * @param request the sling http request to process
      * @param ctx the post processor
      * @return the redirect location or <code>null</code>
      * @deprecated use {@link #getRedirectUrl(HttpServletRequest, 
PostResponse)} instead
@@ -248,6 +251,7 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
     /**
      * compute redirect URL (SLING-126)
      *
+        * @param request the sling http request to process
      * @param ctx the post processor
      * @return the redirect location or <code>null</code>
      */
@@ -326,6 +330,9 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
      * <p>
      * This method may be overwritten by extension if the operation has
      * different requirements on path processing.
+     * </p>
+        * @param request the sling http request to process
+        * @return the resolved path of the found item
      */
     protected String getItemPath(SlingHttpServletRequest request) {
         return request.getResource().getPath();
@@ -335,6 +342,7 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
      * Returns an external form of the given path prepending the context path
      * and appending a display extension.
      *
+        * @param request the sling http request to process
      * @param path the path to externalize
      * @return the url
      */
@@ -413,6 +421,7 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
      *            created if the node does not have one yet.
      * @return The <code>AccessControlList</code> to modify to control access 
to
      *         the node or null if one could not be located or created
+        * @throws RepositoryException if any errors reading the information
      */
     protected AccessControlList getAccessControlListOrNull(
             final AccessControlManager accessControlManager,
@@ -444,6 +453,9 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
 
     /**
      * Bind a new post response creator
+     * 
+     * @param creator the response creator service reference
+     * @param properties the component properties for the service reference
      */
        // NOTE: the @Reference annotation is not inherited, so subclasses will 
need to override the #bindPostResponseCreator 
        // and #unbindPostResponseCreator methods to provide the @Reference 
annotation.     
@@ -473,6 +485,9 @@ public abstract class AbstractAccessPostServlet extends 
SlingAllMethodsServlet {
 
     /**
      * Unbind a post response creator
+     * 
+     * @param creator the response creator service reference
+     * @param properties the component properties for the service reference
      */
     protected void unbindPostResponseCreator(final PostResponseCreator 
creator, final Map<String, Object> properties) {
         synchronized ( this.postResponseCreators ) {
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/DeleteAcesServlet.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/DeleteAcesServlet.java
index 0a1d48b..6bb6550 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/DeleteAcesServlet.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/DeleteAcesServlet.java
@@ -58,6 +58,7 @@ import org.slf4j.LoggerFactory;
  * Delete a set of Ace's from a node, the node is identified as a resource by 
the request
  * url &gt;resource&lt;.deleteAce.html
  * </p>
+ * <h3>Transport Details:</h3>
  * <h4>Methods</h4>
  * <ul>
  * <li>POST</li>
@@ -96,8 +97,6 @@ public class DeleteAcesServlet extends 
AbstractAccessPostServlet implements Dele
 
     /**
      * Overridden since the @Reference annotation is not inherited from the 
super method
-     *  
-        * @see 
org.apache.sling.jackrabbit.usermanager.impl.post.AbstractPostServlet#bindPostResponseCreator(org.apache.sling.servlets.post.PostResponseCreator,
 java.util.Map)
         */
        @Override
     @Reference(service = PostResponseCreator.class,
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetAclServlet.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetAclServlet.java
index c2bd3d7..59c7331 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetAclServlet.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetAclServlet.java
@@ -42,6 +42,7 @@ import org.osgi.service.component.annotations.Component;
  * &gt;resource&lt;.acl.json Provided the user has access to the ACL, they get 
a chunk of
  * JSON of the form.
  * </p>
+ * <h3>Transport Details:</h3>
  * <h4>Methods</h4>
  * <ul>
  * <li>GET</li>
@@ -56,8 +57,7 @@ import org.osgi.service.component.annotations.Component;
  * <dd>Failure. HTML explains the failure.</dd>
  * </dl>
  * <h4>Example Response</h4>
- * <code>
- * <pre>
+ * <code style='white-space: pre'>
  * {
  * &quot;principalNameA&quot;:
  *      { &quot;granted&quot; : [
@@ -94,7 +94,6 @@ import org.osgi.service.component.annotations.Component;
  *           &quot;permission7&quot;,
  *           &quot;permission8&quot;] }
  * }
- * </pre>
  * </code>
  */
 
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetEffectiveAclServlet.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetEffectiveAclServlet.java
index 264345a..5cd722e 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetEffectiveAclServlet.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/GetEffectiveAclServlet.java
@@ -42,6 +42,7 @@ import org.osgi.service.component.annotations.Component;
  * &gt;resource&lt;.acl.json Provided the user has access to the ACL, they get 
a chunk of
  * JSON of the form.
  * </p>
+ * <h3>Transport Details:</h3>
  * <h4>Methods</h4>
  * <ul>
  * <li>GET</li>
@@ -56,8 +57,7 @@ import org.osgi.service.component.annotations.Component;
  * <dd>Failure. HTML explains the failure.</dd>
  * </dl>
  * <h4>Example Response</h4>
- * <code>
- * <pre>
+ * <code style='white-space: pre'>
  * {
  * &quot;principalNameA&quot;:
  *      { &quot;granted&quot; : [
@@ -94,7 +94,6 @@ import org.osgi.service.component.annotations.Component;
  *           &quot;permission7&quot;,
  *           &quot;permission8&quot;] }
  * }
- * </pre>
  * </code>
  */
 
diff --git 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
index 7ef6dd3..356e6a9 100644
--- 
a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
+++ 
b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
@@ -58,6 +58,7 @@ import 
org.osgi.service.component.annotations.ReferencePolicyOption;
  * Modify a principal's ACEs for the node identified as a resource by the 
request
  * URL &gt;resource&lt;.modifyAce.html
  * </p>
+ * <h3>Transport Details:</h3>
  * <h4>Methods</h4>
  * <ul>
  * <li>POST</li>
@@ -70,10 +71,8 @@ import 
org.osgi.service.component.annotations.ReferencePolicyOption;
  * <dd>One or more privileges, either granted or denied or none, which will be 
applied
  * to (or removed from) the node ACL. Any permissions that are present in an
  * existing ACE for the principal but not in the request are left 
untouched.</dd>
- * </dl>
  * <dt>restriction@*</dt>
  * <dd>One or more restrictions which will be applied to the ACE</dd>
- * </dl>
  * <dt>restriction@*@Delete</dt>
  * <dd>One or more restrictions which will be removed from the ACE</dd>
  * </dl>
@@ -120,8 +119,6 @@ public class ModifyAceServlet extends 
AbstractAccessPostServlet implements Modif
     
     /**
      * Overridden since the @Reference annotation is not inherited from the 
super method
-     *  
-        * @see 
org.apache.sling.jackrabbit.usermanager.impl.post.AbstractPostServlet#bindPostResponseCreator(org.apache.sling.servlets.post.PostResponseCreator,
 java.util.Map)
         */
        @Override
     @Reference(service = PostResponseCreator.class,

Reply via email to