This is an automated email from the ASF dual-hosted git repository. olli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-messaging-mail.git
commit d9a98f7f9bac2f43d9129530c317817610bf4742 Author: Oliver Lietz <[email protected]> AuthorDate: Sun Jul 18 13:26:09 2021 +0200 [checkstyle] (modifier) InterfaceMemberImpliedModifier --- pmd-exclude.properties | 21 ++++++ pom.xml | 1 + .../sling/commons/messaging/mail/MailService.java | 4 +- .../commons/messaging/mail/MessageBuilder.java | 74 +++++++++++----------- .../commons/messaging/mail/MessageIdProvider.java | 2 +- 5 files changed, 62 insertions(+), 40 deletions(-) diff --git a/pmd-exclude.properties b/pmd-exclude.properties new file mode 100644 index 0000000..a748f15 --- /dev/null +++ b/pmd-exclude.properties @@ -0,0 +1,21 @@ +################################################################################ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +################################################################################ +org.apache.sling.commons.messaging.mail.MailService=UnnecessaryModifier +org.apache.sling.commons.messaging.mail.MessageBuilder=UnnecessaryModifier +org.apache.sling.commons.messaging.mail.MessageIdProvider=UnnecessaryModifier diff --git a/pom.xml b/pom.xml index 762a779..e0547c9 100644 --- a/pom.xml +++ b/pom.xml @@ -114,6 +114,7 @@ <version>3.14.0</version> <configuration> <targetJdk>${sling.java.version}</targetJdk> + <excludeFromFailureFile>pmd-exclude.properties</excludeFromFailureFile> </configuration> <executions> <execution> diff --git a/src/main/java/org/apache/sling/commons/messaging/mail/MailService.java b/src/main/java/org/apache/sling/commons/messaging/mail/MailService.java index 854731e..0b1af4a 100644 --- a/src/main/java/org/apache/sling/commons/messaging/mail/MailService.java +++ b/src/main/java/org/apache/sling/commons/messaging/mail/MailService.java @@ -29,8 +29,8 @@ import org.osgi.annotation.versioning.ProviderType; @ProviderType public interface MailService extends MessageService<MimeMessage, Void> { - @NotNull MessageBuilder getMessageBuilder(); + public abstract @NotNull MessageBuilder getMessageBuilder(); - @NotNull CompletableFuture<Void> sendMessage(@NotNull final MimeMessage message); + public abstract @NotNull CompletableFuture<Void> sendMessage(@NotNull MimeMessage message); } diff --git a/src/main/java/org/apache/sling/commons/messaging/mail/MessageBuilder.java b/src/main/java/org/apache/sling/commons/messaging/mail/MessageBuilder.java index bfb504d..52e926e 100644 --- a/src/main/java/org/apache/sling/commons/messaging/mail/MessageBuilder.java +++ b/src/main/java/org/apache/sling/commons/messaging/mail/MessageBuilder.java @@ -33,78 +33,78 @@ import org.osgi.annotation.versioning.ProviderType; @ProviderType public interface MessageBuilder { - @NotNull MessageBuilder header(@NotNull final String name, @Nullable final String value); + public abstract @NotNull MessageBuilder header(@NotNull final String name, @Nullable final String value); - @NotNull MessageBuilder headers(@NotNull final Collection<Header> headers); + public abstract @NotNull MessageBuilder headers(@NotNull final Collection<Header> headers); - @NotNull MessageBuilder from(@NotNull final InternetAddress from); + public abstract @NotNull MessageBuilder from(@NotNull final InternetAddress from); - @NotNull MessageBuilder from(@NotNull final String address) throws AddressException; + public abstract @NotNull MessageBuilder from(@NotNull final String address) throws AddressException; - @NotNull MessageBuilder from(@NotNull final String address, @NotNull final String name) throws AddressException; + public abstract @NotNull MessageBuilder from(@NotNull final String address, @NotNull final String name) throws AddressException; - @NotNull MessageBuilder to(@NotNull final InternetAddress to); + public abstract @NotNull MessageBuilder to(@NotNull final InternetAddress to); - @NotNull MessageBuilder to(@NotNull final String address) throws AddressException; + public abstract @NotNull MessageBuilder to(@NotNull final String address) throws AddressException; - @NotNull MessageBuilder to(@NotNull final String address, @NotNull final String name) throws AddressException; + public abstract @NotNull MessageBuilder to(@NotNull final String address, @NotNull final String name) throws AddressException; - @NotNull MessageBuilder to(@NotNull final InternetAddress[] addresses); + public abstract @NotNull MessageBuilder to(@NotNull final InternetAddress[] addresses); - @NotNull MessageBuilder to(@NotNull final String[] addresses) throws AddressException; + public abstract @NotNull MessageBuilder to(@NotNull final String[] addresses) throws AddressException; - @NotNull MessageBuilder to(@NotNull final Collection<String> addresses) throws AddressException; + public abstract @NotNull MessageBuilder to(@NotNull final Collection<String> addresses) throws AddressException; - @NotNull MessageBuilder cc(@NotNull final InternetAddress cc); + public abstract @NotNull MessageBuilder cc(@NotNull final InternetAddress cc); - @NotNull MessageBuilder cc(@NotNull final String address) throws AddressException; + public abstract @NotNull MessageBuilder cc(@NotNull final String address) throws AddressException; - @NotNull MessageBuilder cc(@NotNull final String address, @NotNull final String name) throws AddressException; + public abstract @NotNull MessageBuilder cc(@NotNull final String address, @NotNull final String name) throws AddressException; - @NotNull MessageBuilder cc(@NotNull final InternetAddress[] addresses); + public abstract @NotNull MessageBuilder cc(@NotNull final InternetAddress[] addresses); - @NotNull MessageBuilder cc(@NotNull final String[] addresses) throws AddressException; + public abstract @NotNull MessageBuilder cc(@NotNull final String[] addresses) throws AddressException; - @NotNull MessageBuilder cc(@NotNull final Collection<String> addresses) throws AddressException; + public abstract @NotNull MessageBuilder cc(@NotNull final Collection<String> addresses) throws AddressException; - @NotNull MessageBuilder bcc(@NotNull final InternetAddress bcc); + public abstract @NotNull MessageBuilder bcc(@NotNull final InternetAddress bcc); - @NotNull MessageBuilder bcc(@NotNull final String address) throws AddressException; + public abstract @NotNull MessageBuilder bcc(@NotNull final String address) throws AddressException; - @NotNull MessageBuilder bcc(@NotNull final String address, final String name) throws AddressException; + public abstract @NotNull MessageBuilder bcc(@NotNull final String address, final String name) throws AddressException; - @NotNull MessageBuilder bcc(@NotNull final InternetAddress[] addresses); + public abstract @NotNull MessageBuilder bcc(@NotNull final InternetAddress[] addresses); - @NotNull MessageBuilder bcc(@NotNull final String[] addresses) throws AddressException; + public abstract @NotNull MessageBuilder bcc(@NotNull final String[] addresses) throws AddressException; - @NotNull MessageBuilder bcc(@NotNull final Collection<String> addresses) throws AddressException; + public abstract @NotNull MessageBuilder bcc(@NotNull final Collection<String> addresses) throws AddressException; - @NotNull MessageBuilder replyTo(@NotNull final InternetAddress replyTo); + public abstract @NotNull MessageBuilder replyTo(@NotNull final InternetAddress replyTo); - @NotNull MessageBuilder replyTo(@NotNull final String address) throws AddressException; + public abstract @NotNull MessageBuilder replyTo(@NotNull final String address) throws AddressException; - @NotNull MessageBuilder replyTo(@NotNull final String address, final String name) throws AddressException; + public abstract @NotNull MessageBuilder replyTo(@NotNull final String address, final String name) throws AddressException; - @NotNull MessageBuilder replyTo(@NotNull final InternetAddress[] addresses); + public abstract @NotNull MessageBuilder replyTo(@NotNull final InternetAddress[] addresses); - @NotNull MessageBuilder replyTo(@NotNull final String[] addresses) throws AddressException; + public abstract @NotNull MessageBuilder replyTo(@NotNull final String[] addresses) throws AddressException; - @NotNull MessageBuilder replyTo(@NotNull final Collection<String> addresses) throws AddressException; + public abstract @NotNull MessageBuilder replyTo(@NotNull final Collection<String> addresses) throws AddressException; - @NotNull MessageBuilder subject(@NotNull final String subject); + public abstract @NotNull MessageBuilder subject(@NotNull final String subject); - @NotNull MessageBuilder text(@NotNull final String text); + public abstract @NotNull MessageBuilder text(@NotNull final String text); - @NotNull MessageBuilder html(@NotNull final String html); + public abstract @NotNull MessageBuilder html(@NotNull final String html); - @NotNull MessageBuilder attachment(final byte @NotNull [] content, @NotNull final String type, @NotNull final String filename); + public abstract @NotNull MessageBuilder attachment(final byte @NotNull [] content, @NotNull final String type, @NotNull final String filename); - @NotNull MessageBuilder attachment(final byte @NotNull [] content, @NotNull final String type, @NotNull final String filename, @Nullable final Collection<Header> headers); + public abstract @NotNull MessageBuilder attachment(final byte @NotNull [] content, @NotNull final String type, @NotNull final String filename, @Nullable final Collection<Header> headers); - @NotNull MessageBuilder inline(final byte @NotNull [] content, @NotNull final String type, @NotNull final String cid); + public abstract @NotNull MessageBuilder inline(final byte @NotNull [] content, @NotNull final String type, @NotNull final String cid); - @NotNull MessageBuilder inline(final byte @NotNull [] content, @NotNull final String type, @NotNull final String cid, @Nullable final Collection<Header> headers); + public abstract @NotNull MessageBuilder inline(final byte @NotNull [] content, @NotNull final String type, @NotNull final String cid, @Nullable final Collection<Header> headers); - @NotNull MimeMessage build() throws MessagingException; + public abstract @NotNull MimeMessage build() throws MessagingException; } diff --git a/src/main/java/org/apache/sling/commons/messaging/mail/MessageIdProvider.java b/src/main/java/org/apache/sling/commons/messaging/mail/MessageIdProvider.java index a8288c9..00259c2 100644 --- a/src/main/java/org/apache/sling/commons/messaging/mail/MessageIdProvider.java +++ b/src/main/java/org/apache/sling/commons/messaging/mail/MessageIdProvider.java @@ -27,6 +27,6 @@ import org.osgi.annotation.versioning.ProviderType; @ProviderType public interface MessageIdProvider { - @NotNull String getMessageId(@NotNull final MimeMessage message) throws MessagingException; + public abstract @NotNull String getMessageId(@NotNull final MimeMessage message) throws MessagingException; }
