cschneider commented on code in PR #13:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#discussion_r970726120


##########
src/main/java/org/apache/sling/distribution/journal/MessagingProvider.java:
##########
@@ -62,11 +62,14 @@ default Closeable createPoller(
      * @param topicName name of the topic
      * @param reset fallback in case no assign is given or the assigned offset 
not valid
      * @param assign opaque implementation dependent assign string (can be 
null)
-     * @param properties list of properties to filter the topic
+     * @param filterProperties list of properties used to filter the topic 
messages.

Review Comment:
   I would describe this only in an abstract way like:
   List of properties used to filter the topic messages. Only messages that 
match all filterProperties keys and values will be received.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to