cschneider commented on code in PR #114:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/114#discussion_r1104158486
##########
src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributedEventNotifierManager.java:
##########
@@ -57,20 +58,22 @@ public class DistributedEventNotifierManager implements
TopologyEventListener, R
* to the configuration.
*/
- @Reference
- private EventAdmin eventAdmin;
+ private final EventAdmin eventAdmin;
- @Reference
- private PubQueueProvider pubQueueCacheService;
+ private final PubQueueProvider pubQueueCacheService;
- @Reference
- private MessagingProvider messagingProvider;
+ private final MessagingProvider messagingProvider;
- @Reference
- private Topics topics;
+ private final Topics topics;
- @Reference
- private ResourceResolverFactory resolverFactory;
+ private final ResourceResolverFactory resolverFactory;
+
+ /**
Review Comment:
You should document that this reference should be pointed to the event
handler that is supposed to definetely get the events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
