This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new 67ebe8720cb Add not null assertions for PlacementPluginIntegrationTest
67ebe8720cb is described below

commit 67ebe8720cbb3082a6d86e317105dc64ccad24dc
Author: Kevin Risden <[email protected]>
AuthorDate: Thu Feb 23 10:28:47 2023 -0500

    Add not null assertions for PlacementPluginIntegrationTest
---
 .../solr/cluster/placement/impl/PlacementPluginIntegrationTest.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git 
a/solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
 
b/solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
index f1ade4059a5..fb7d769d1c9 100644
--- 
a/solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
+++ 
b/solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
@@ -142,6 +142,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
   public void testDynamicReconfiguration() throws Exception {
     PlacementPluginFactory<? extends PlacementPluginConfig> pluginFactory =
         cc.getPlacementPluginFactory();
+    assertNotNull(pluginFactory);
     assertTrue(
         "wrong type " + pluginFactory.getClass().getName(),
         pluginFactory instanceof DelegatingPlacementPluginFactory);
@@ -165,6 +166,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
 
     version = phaser.awaitAdvanceInterruptibly(version, 10, TimeUnit.SECONDS);
     PlacementPluginFactory<? extends PlacementPluginConfig> factory = 
wrapper.getDelegate();
+    assertNotNull(factory);
     assertTrue(
         "wrong type " + factory.getClass().getName(),
         factory instanceof MinimizeCoresPlacementFactory);
@@ -183,6 +185,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
     version = phaser.awaitAdvanceInterruptibly(version, 10, TimeUnit.SECONDS);
 
     factory = wrapper.getDelegate();
+    assertNotNull(factory);
     assertTrue(
         "wrong type " + factory.getClass().getName(), factory instanceof 
AffinityPlacementFactory);
     AffinityPlacementConfig config = ((AffinityPlacementFactory) 
factory).getConfig();
@@ -201,6 +204,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
 
     version = phaser.awaitAdvanceInterruptibly(version, 10, TimeUnit.SECONDS);
     factory = wrapper.getDelegate();
+    assertNotNull(factory);
     assertTrue(
         "wrong type " + factory.getClass().getName(), factory instanceof 
AffinityPlacementFactory);
     config = ((AffinityPlacementFactory) factory).getConfig();
@@ -237,6 +241,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
   public void testWithCollectionIntegration() throws Exception {
     PlacementPluginFactory<? extends PlacementPluginConfig> pluginFactory =
         cc.getPlacementPluginFactory();
+    assertNotNull(pluginFactory);
     assertTrue(
         "wrong type " + pluginFactory.getClass().getName(),
         pluginFactory instanceof DelegatingPlacementPluginFactory);
@@ -347,6 +352,7 @@ public class PlacementPluginIntegrationTest extends 
SolrCloudTestCase {
 
     PlacementPluginFactory<? extends PlacementPluginConfig> pluginFactory =
         cc.getPlacementPluginFactory();
+    assertNotNull(pluginFactory);
     assertTrue(
         "wrong type " + pluginFactory.getClass().getName(),
         pluginFactory instanceof DelegatingPlacementPluginFactory);

Reply via email to