(solr) branch main updated: SOLR-18174 Ignore flaky test testSemaphoreLeakOnLBRetry (#4503)

[janhoy]

This is an automated email from the ASF dual-hosted git repository.

janhoy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new 20baecf6e45 SOLR-18174 Ignore flaky test testSemaphoreLeakOnLBRetry 
(#4503)
20baecf6e45 is described below

commit 20baecf6e4528bec60056474763880fba84af96d
Author: Jan Høydahl <jan...@apache.org>
AuthorDate: Sun Jun 7 03:16:35 2026 +0200

    SOLR-18174 Ignore flaky test testSemaphoreLeakOnLBRetry (#4503)
---
 .../solr/handler/component/AsyncTrackerSemaphoreLeakTest.java  | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git 
a/solr/core/src/test/org/apache/solr/handler/component/AsyncTrackerSemaphoreLeakTest.java
 
b/solr/core/src/test/org/apache/solr/handler/component/AsyncTrackerSemaphoreLeakTest.java
index fb04ec1ef67..a1152bac141 100644
--- 
a/solr/core/src/test/org/apache/solr/handler/component/AsyncTrackerSemaphoreLeakTest.java
+++ 
b/solr/core/src/test/org/apache/solr/handler/component/AsyncTrackerSemaphoreLeakTest.java
@@ -46,6 +46,7 @@ import org.eclipse.jetty.client.Response;
 import org.eclipse.jetty.client.Result;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;
@@ -116,11 +117,12 @@ public class AsyncTrackerSemaphoreLeakTest extends 
SolrCloudTestCase {
    * org.apache.solr.client.solrj.jetty.LBJettySolrClient} retrying a request 
synchronously inside a
    * {@link CompletableFuture#whenComplete} callback that runs on the Jetty IO 
selector thread.
    *
-   * <p>This test <b>passes</b> with the {@code failureDispatchExecutor} fix 
in this branch. Without
-   * the fix, the IO thread would block forever in {@code semaphore.acquire()} 
and this test would
-   * time out.
+   * <p>Without the {@code failureDispatchExecutor} fix (SOLR-18174), the IO 
thread would block
+   * forever in {@code semaphore.acquire()} and this test would time out.
    */
   @Test
+  @Ignore(
+      "SOLR-18174: Flaky due to timing-sensitive TCP RST simulation; kept for 
regression testing")
   public void testSemaphoreLeakOnLBRetry() throws Exception {
     // Dedicated client so that permanently deadlocked IO threads don't affect 
the cluster's client.
     HttpJettySolrClient testClient =
@@ -312,7 +314,7 @@ public class AsyncTrackerSemaphoreLeakTest extends 
SolrCloudTestCase {
           permitsAfter);
 
     } finally {
-      // Force-terminate the Phaser as a safety net; without the fix the 
phaser would be unbalanced.
+      // Force-terminate the Phaser as a safety net in case the phaser is 
unbalanced.
       try {
         Field phaserField = asyncTrackerClass.getDeclaredField("phaser");
         phaserField.setAccessible(true);