Repository: spark Updated Branches: refs/heads/master 2fedb5ddd -> 8cc70e7e1
[SQL] Kill dangerous trailing space in query string MD5 of query strings in `createQueryTest` calls are used to generate golden files, leaving trailing spaces there can be really dangerous. Got bitten by this while working on #2616: my "smart" IDE automatically removed a trailing space and makes Jenkins fail. (Really should add "no trailing space" to our coding style guidelines!) Author: Cheng Lian <[email protected]> Closes #2619 from liancheng/kill-trailing-space and squashes the following commits: 034f119 [Cheng Lian] Kill dangerous trailing space in query string Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/8cc70e7e Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/8cc70e7e Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/8cc70e7e Branch: refs/heads/master Commit: 8cc70e7e15fd800f31b94e9102069506360289db Parents: 2fedb5d Author: Cheng Lian <[email protected]> Authored: Wed Oct 1 12:40:37 2014 -0700 Committer: Michael Armbrust <[email protected]> Committed: Wed Oct 1 12:40:37 2014 -0700 ---------------------------------------------------------------------- ...imestamp to Timestamp in UDF-0-66952a3949d7544716fd1a675498b1fa | 1 - ...imestamp to Timestamp in UDF-0-db6d4503454e4dbb9edcbab9a8718d7f | 1 + .../scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/8cc70e7e/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-66952a3949d7544716fd1a675498b1fa ---------------------------------------------------------------------- diff --git a/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-66952a3949d7544716fd1a675498b1fa b/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-66952a3949d7544716fd1a675498b1fa deleted file mode 100644 index 7951def..0000000 --- a/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-66952a3949d7544716fd1a675498b1fa +++ /dev/null @@ -1 +0,0 @@ -NULL http://git-wip-us.apache.org/repos/asf/spark/blob/8cc70e7e/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-db6d4503454e4dbb9edcbab9a8718d7f ---------------------------------------------------------------------- diff --git a/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-db6d4503454e4dbb9edcbab9a8718d7f b/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-db6d4503454e4dbb9edcbab9a8718d7f new file mode 100644 index 0000000..7951def --- /dev/null +++ b/sql/hive/src/test/resources/golden/Cast Timestamp to Timestamp in UDF-0-db6d4503454e4dbb9edcbab9a8718d7f @@ -0,0 +1 @@ +NULL http://git-wip-us.apache.org/repos/asf/spark/blob/8cc70e7e/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ---------------------------------------------------------------------- diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala index 2da8a6f..f5868bf 100644 --- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala +++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala @@ -164,7 +164,7 @@ class HiveQuerySuite extends HiveComparisonTest { createQueryTest("Cast Timestamp to Timestamp in UDF", """ - | SELECT DATEDIFF(CAST(value AS timestamp), CAST('2002-03-21 00:00:00' AS timestamp)) + | SELECT DATEDIFF(CAST(value AS timestamp), CAST('2002-03-21 00:00:00' AS timestamp)) | FROM src LIMIT 1 """.stripMargin) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
