Repository: spark Updated Branches: refs/heads/master 5b99bf243 -> 052e65815
Delete unnecessary function when building spark by sbt, the function ârunAlternateBoot" in sbt/sbt-launch-lib.bash is not used. And this function is not used by spark code. So I think this function is not necessary. And the option of "sbt.boot.properties" can be configured in the command line when building spark, eg: sbt/sbt assembly -Dsbt.boot.properties=$bootpropsfile. The file from https://github.com/sbt/sbt-launcher-package is changed. And the function ârunAlternateBoot" is deleted in upstream project. I think spark project should delete this function in file sbt/sbt-launch-lib.bash. Thanks. Author: KaiXinXiaoLei <[email protected]> Closes #3224 from KaiXinXiaoLei/deleteFunction and squashes the following commits: e8eac49 [KaiXinXiaoLei] Delete blank lines. efe36d4 [KaiXinXiaoLei] Delete unnecessary function Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/052e6581 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/052e6581 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/052e6581 Branch: refs/heads/master Commit: 052e65815f23ee92a2093a8059d7fd192b1526e5 Parents: 5b99bf2 Author: KaiXinXiaoLei <[email protected]> Authored: Fri Nov 28 12:34:07 2014 -0500 Committer: Patrick Wendell <[email protected]> Committed: Fri Nov 28 12:34:07 2014 -0500 ---------------------------------------------------------------------- sbt/sbt-launch-lib.bash | 7 ------- 1 file changed, 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/052e6581/sbt/sbt-launch-lib.bash ---------------------------------------------------------------------- diff --git a/sbt/sbt-launch-lib.bash b/sbt/sbt-launch-lib.bash index 055e206..84a6f7a 100755 --- a/sbt/sbt-launch-lib.bash +++ b/sbt/sbt-launch-lib.bash @@ -186,10 +186,3 @@ run() { "${sbt_commands[@]}" \ "${residual_args[@]}" } - -runAlternateBoot() { - local bootpropsfile="$1" - shift - addJava "-Dsbt.boot.properties=$bootpropsfile" - run $@ -} --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
