Repository: spark
Updated Branches:
  refs/heads/branch-1.2 755f9cc40 -> 71471bd79


[SPARK-4973][CORE] Local directory in the driver of client-mode continues 
remaining even if application finished when external shuffle is enabled

When we enables external shuffle service, local directories in the driver of 
client-mode continue remaining even if application has finished.
I think local directories for drivers should be deleted.

Author: Kousuke Saruta <[email protected]>

Closes #3811 from sarutak/SPARK-4973 and squashes the following commits:

ad944ab [Kousuke Saruta] Fixed DiskBlockManager to cleanup local directory if 
it's the driver
43770da [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark 
into SPARK-4973
88feecd [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark 
into SPARK-4973
d99718e [Kousuke Saruta] Fixed SparkSubmit.scala and DiskBlockManager.scala in 
order to delete local directories of the driver of local-mode when external 
shuffle service is enabled

(cherry picked from commit a00af6bec57b8df8b286aaa5897232475aef441c)
Signed-off-by: Andrew Or <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/71471bd7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/71471bd7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/71471bd7

Branch: refs/heads/branch-1.2
Commit: 71471bd79579e6cbbced1f4ccea6fcecc9bfc656
Parents: 755f9cc
Author: Kousuke Saruta <[email protected]>
Authored: Thu Jan 8 13:43:09 2015 -0800
Committer: Andrew Or <[email protected]>
Committed: Thu Jan 8 13:43:20 2015 -0800

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/storage/DiskBlockManager.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/71471bd7/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
----------------------------------------------------------------------
diff --git 
a/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala 
b/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
index 58fba54..d79ed76 100644
--- a/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
+++ b/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
@@ -164,7 +164,7 @@ private[spark] class DiskBlockManager(blockManager: 
BlockManager, conf: SparkCon
   /** Cleanup local dirs and stop shuffle sender. */
   private[spark] def stop() {
     // Only perform cleanup if an external service is not serving our shuffle 
files.
-    if (!blockManager.externalShuffleServiceEnabled) {
+    if (!blockManager.externalShuffleServiceEnabled || 
blockManager.blockManagerId.isDriver) {
       localDirs.foreach { localDir =>
         if (localDir.isDirectory() && localDir.exists()) {
           try {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to