Repository: spark Updated Branches: refs/heads/master f133dece5 -> ef65cf09b
[SPARK-5540] hide ALS.solveLeastSquares This method survived the code review and it has been there since v1.1.0. It exposes jblas types. Let's remove it from the public API. I think no one calls it directly. Author: Xiangrui Meng <[email protected]> Closes #4318 from mengxr/SPARK-5540 and squashes the following commits: 586ade6 [Xiangrui Meng] hide ALS.solveLeastSquares Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ef65cf09 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ef65cf09 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ef65cf09 Branch: refs/heads/master Commit: ef65cf09b04f915ab463a6d3bac12795318897f2 Parents: f133dec Author: Xiangrui Meng <[email protected]> Authored: Mon Feb 2 17:10:01 2015 -0800 Committer: Xiangrui Meng <[email protected]> Committed: Mon Feb 2 17:10:01 2015 -0800 ---------------------------------------------------------------------- .../main/scala/org/apache/spark/mllib/recommendation/ALS.scala | 2 +- project/MimaExcludes.scala | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/ef65cf09/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---------------------------------------------------------------------- diff --git a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala index 5f84677..a5ffe88 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala @@ -615,7 +615,7 @@ class ALS private ( * Given A^T A and A^T b, find the x minimising ||Ax - b||_2, possibly subject * to nonnegativity constraints if `nonnegative` is true. */ - def solveLeastSquares(ata: DoubleMatrix, atb: DoubleMatrix, + private def solveLeastSquares(ata: DoubleMatrix, atb: DoubleMatrix, ws: NNLS.Workspace): Array[Double] = { if (!nonnegative) { Solve.solvePositive(ata, atb).data http://git-wip-us.apache.org/repos/asf/spark/blob/ef65cf09/project/MimaExcludes.scala ---------------------------------------------------------------------- diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index 45be1db..78de1f0 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -67,6 +67,10 @@ object MimaExcludes { ProblemFilters.exclude[MissingMethodProblem]( "org.apache.spark.mllib.linalg.Matrix.foreachActive") ) ++ Seq( + // SPARK-5540 + ProblemFilters.exclude[MissingMethodProblem]( + "org.apache.spark.mllib.recommendation.ALS.solveLeastSquares") + ) ++ Seq( // SPARK-3325 ProblemFilters.exclude[MissingMethodProblem]( "org.apache.spark.streaming.api.java.JavaDStreamLike.print"), --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
