Repository: spark
Updated Branches:
  refs/heads/master f149b8b5e -> e3f315ac3


[SPARK-6327] [PySpark] fix launch spark-submit from python

SparkSubmit should be launched without setting PYSPARK_SUBMIT_ARGS

cc JoshRosen , this mode is actually used by python unit test, so I will not 
add more test for it.

Author: Davies Liu <dav...@databricks.com>

Closes #5019 from davies/fix_submit and squashes the following commits:

2c20b0c [Davies Liu] fix launch spark-submit from python


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e3f315ac
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e3f315ac
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e3f315ac

Branch: refs/heads/master
Commit: e3f315ac358dfe4f5b9705c3eac76e8b1e24f82a
Parents: f149b8b
Author: Davies Liu <dav...@databricks.com>
Authored: Mon Mar 16 16:26:55 2015 -0700
Committer: Josh Rosen <joshro...@databricks.com>
Committed: Mon Mar 16 16:26:55 2015 -0700

----------------------------------------------------------------------
 bin/pyspark                    | 1 -
 python/pyspark/java_gateway.py | 6 ++----
 2 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/e3f315ac/bin/pyspark
----------------------------------------------------------------------
diff --git a/bin/pyspark b/bin/pyspark
index e7f6a1a..776b28d 100755
--- a/bin/pyspark
+++ b/bin/pyspark
@@ -89,7 +89,6 @@ export PYTHONSTARTUP="$SPARK_HOME/python/pyspark/shell.py"
 if [[ -n "$SPARK_TESTING" ]]; then
   unset YARN_CONF_DIR
   unset HADOOP_CONF_DIR
-  export PYSPARK_SUBMIT_ARGS=pyspark-shell
   if [[ -n "$PYSPARK_DOC_TEST" ]]; then
     exec "$PYSPARK_DRIVER_PYTHON" -m doctest $1
   else

http://git-wip-us.apache.org/repos/asf/spark/blob/e3f315ac/python/pyspark/java_gateway.py
----------------------------------------------------------------------
diff --git a/python/pyspark/java_gateway.py b/python/pyspark/java_gateway.py
index 43d2cf5..0a16cbd 100644
--- a/python/pyspark/java_gateway.py
+++ b/python/pyspark/java_gateway.py
@@ -38,10 +38,8 @@ def launch_gateway():
         # proper classpath and settings from spark-env.sh
         on_windows = platform.system() == "Windows"
         script = "./bin/spark-submit.cmd" if on_windows else 
"./bin/spark-submit"
-        submit_args = os.environ.get("PYSPARK_SUBMIT_ARGS")
-        submit_args = submit_args if submit_args is not None else ""
-        submit_args = shlex.split(submit_args)
-        command = [os.path.join(SPARK_HOME, script)] + submit_args
+        submit_args = os.environ.get("PYSPARK_SUBMIT_ARGS", "pyspark-shell")
+        command = [os.path.join(SPARK_HOME, script)] + shlex.split(submit_args)
 
         # Start a socket that will be used by PythonGatewayServer to 
communicate its port to us
         callback_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to