Repository: spark Updated Branches: refs/heads/master be0dcd6eb -> ae6570ec2
Remove TODO in ShuffleMemoryManager. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ae6570ec Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ae6570ec Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ae6570ec Branch: refs/heads/master Commit: ae6570ec2bf937e28bd1e7bada7813ac56a7b79d Parents: be0dcd6 Author: Reynold Xin <[email protected]> Authored: Sat Oct 3 18:08:25 2015 -0700 Committer: Reynold Xin <[email protected]> Committed: Sat Oct 3 18:08:25 2015 -0700 ---------------------------------------------------------------------- .../main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala | 1 - 1 file changed, 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/ae6570ec/core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala b/core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala index a0d8abc..9839c76 100644 --- a/core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala +++ b/core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala @@ -177,7 +177,6 @@ private[spark] object ShuffleMemoryManager { val cores = if (numCores > 0) numCores else Runtime.getRuntime.availableProcessors() // Because of rounding to next power of 2, we may have safetyFactor as 8 in worst case val safetyFactor = 16 - // TODO(davies): don't round to next power of 2 val size = ByteArrayMethods.nextPowerOf2(maxMemory / cores / safetyFactor) val default = math.min(maxPageSize, math.max(minPageSize, size)) conf.getSizeAsBytes("spark.buffer.pageSize", default) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
