Repository: spark Updated Branches: refs/heads/master 726bd3c4e -> 794ea553b
[SPARK-12692][BUILD] Scala style: check no white space before comma and colon We should not put a white space before `,` and `:` so let's check it. Because there are lots of style violations, first, I'd like to add a checker, enable and let the level `warning`. Then, I'd like to fix the style step by step. Author: Kousuke Saruta <[email protected]> Closes #10643 from sarutak/SPARK-12692. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/794ea553 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/794ea553 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/794ea553 Branch: refs/heads/master Commit: 794ea553bd0fcfece15b610b47ee86d6644134c9 Parents: 726bd3c Author: Kousuke Saruta <[email protected]> Authored: Fri Jan 8 00:53:15 2016 -0800 Committer: Reynold Xin <[email protected]> Committed: Fri Jan 8 00:53:15 2016 -0800 ---------------------------------------------------------------------- scalastyle-config.xml | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/794ea553/scalastyle-config.xml ---------------------------------------------------------------------- diff --git a/scalastyle-config.xml b/scalastyle-config.xml index ee855ca..9714c46 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -218,6 +218,12 @@ This file is divided into 3 sections: </parameters> </check> + <!-- Should turn this on, but we have a few places that need to be fixed first --> + <check level="warning" class="org.scalastyle.scalariform.DisallowSpaceBeforeTokenChecker" enabled="true"> + <parameters> + <parameter name="tokens">COLON, COMMA</parameter> + </parameters> + </check> <!-- ================================================================================ --> <!-- rules we don't want --> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
