Repository: spark Updated Branches: refs/heads/branch-2.0 036c22494 -> 1d18a6d3b
[SPARK-15229][SQL] Make case sensitivity setting internal ## What changes were proposed in this pull request? Our case sensitivity support is different from what ANSI SQL standards support. Postgres' behavior is that if an identifier is quoted, then it is treated as case sensitive; otherwise it is folded to lowercase. We will likely need to revisit this in the future and change our behavior. For now, the safest change to do for Spark 2.0 is to make the case sensitive option internal and discourage users from turning it on, effectively making Spark always case insensitive. ## How was this patch tested? N/A - a small config documentation change. Author: Reynold Xin <[email protected]> Closes #13011 from rxin/SPARK-15229. (cherry picked from commit 4b4344a81331e48b0a00032ec8285f33cc09788a) Signed-off-by: Reynold Xin <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/1d18a6d3 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/1d18a6d3 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/1d18a6d3 Branch: refs/heads/branch-2.0 Commit: 1d18a6d3b36d090e8e3305d3b9ffcd4bda86405f Parents: 036c224 Author: Reynold Xin <[email protected]> Authored: Mon May 9 20:03:01 2016 -0700 Committer: Reynold Xin <[email protected]> Committed: Mon May 9 20:03:07 2016 -0700 ---------------------------------------------------------------------- .../src/main/scala/org/apache/spark/sql/internal/SQLConf.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/1d18a6d3/sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---------------------------------------------------------------------- diff --git a/sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala b/sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala index 5e19984..7933d12 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala @@ -167,7 +167,9 @@ object SQLConf { .createWithDefault(true) val CASE_SENSITIVE = SQLConfigBuilder("spark.sql.caseSensitive") - .doc("Whether the query analyzer should be case sensitive or not. Default to case insensitive.") + .internal() + .doc("Whether the query analyzer should be case sensitive or not. " + + "Default to case insensitive. It is highly discouraged to turn on case sensitive mode.") .booleanConf .createWithDefault(false) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
