Repository: spark
Updated Branches:
  refs/heads/master 7222a25a1 -> 6f2fa6c54


[SPARK-11272][WEB UI] Add support for downloading event logs from HistoryServer 
UI

## What changes were proposed in this pull request?

This is a reworked PR based on feedback in #9238 after it was closed and not 
reopened. As suggested in that PR I've only added the download feature. This 
functionality already exists in the api and this allows easier access to 
download event logs to share with others.

I've attached a screenshot of the committed version, but I will also include 
alternate options with screen shots in the comments below. I'm personally not 
sure which option is best.

## How was this patch tested?

Manual testing

![screen shot 2016-10-07 at 6 11 12 
pm](https://cloud.githubusercontent.com/assets/13952758/19209213/832fe48e-8cba-11e6-9840-749b1be4d399.png)

Author: Alex Bozarth <ajboz...@us.ibm.com>

Closes #15400 from ajbozarth/spark11272.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6f2fa6c5
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6f2fa6c5
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6f2fa6c5

Branch: refs/heads/master
Commit: 6f2fa6c54a11caccd446d5560d2014c645fcf7cc
Parents: 7222a25
Author: Alex Bozarth <ajboz...@us.ibm.com>
Authored: Thu Oct 13 03:24:37 2016 -0400
Committer: Andrew Or <andrewo...@gmail.com>
Committed: Thu Oct 13 03:24:37 2016 -0400

----------------------------------------------------------------------
 .../org/apache/spark/ui/static/historypage-template.html      | 7 ++++++-
 .../main/resources/org/apache/spark/ui/static/historypage.js  | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/6f2fa6c5/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
----------------------------------------------------------------------
diff --git 
a/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html 
b/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
index a2b3826..1fd6ef4 100644
--- 
a/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
+++ 
b/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
@@ -59,7 +59,11 @@
           Last Updated
         </span>
       </th>
-    </tr>
+      <th>
+        <span data-toggle="tooltip" data-placement="above" title="Download the 
event log for this application">
+          Event Log
+        </span>
+      </th>
   </thead>
   <tbody>
   {{#applications}}
@@ -73,6 +77,7 @@
       <td><span title="{{duration}}" 
class="durationClass">{{duration}}</span></td>
       <td>{{sparkUser}}</td>
       <td>{{lastUpdated}}</td>
+      <td><a href="/api/v1/applications/{{id}}/{{num}}/logs" class="btn 
btn-info btn-mini">Download</a></td>
       {{/attempts}}
     </tr>
   {{/applications}}

http://git-wip-us.apache.org/repos/asf/spark/blob/6f2fa6c5/core/src/main/resources/org/apache/spark/ui/static/historypage.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/historypage.js 
b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
index c809400..2a32e18 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/historypage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
@@ -133,6 +133,7 @@ $(document).ready(function() {
                         {name: 'sixth', type: "title-numeric"},
                         {name: 'seventh'},
                         {name: 'eighth'},
+                        {name: 'ninth'},
                     ],
                     "autoWidth": false,
                     "order": [[ 4, "desc" ]]


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to