Repository: spark
Updated Branches:
refs/heads/branch-2.0 e8923d21d -> 6cc6cb2a9
[SPARKR] fix warnings
## What changes were proposed in this pull request?
Fix for a bunch of test warnings that were added recently.
We need to investigate why warnings are not turning into errors.
```
Warnings -----------------------------------------------------------------------
1. createDataFrame uses files for large objects (test_sparkSQL.R#215) - Use
Sepal_Length instead of Sepal.Length as column name
2. createDataFrame uses files for large objects (test_sparkSQL.R#215) - Use
Sepal_Width instead of Sepal.Width as column name
3. createDataFrame uses files for large objects (test_sparkSQL.R#215) - Use
Petal_Length instead of Petal.Length as column name
4. createDataFrame uses files for large objects (test_sparkSQL.R#215) - Use
Petal_Width instead of Petal.Width as column name
Consider adding
importFrom("utils", "object.size")
to your NAMESPACE file.
```
## How was this patch tested?
unit tests
Author: Felix Cheung <[email protected]>
Closes #15560 from felixcheung/rwarnings.
(cherry picked from commit 3180272d2d49e440516085c0e4aebd5bad18bcad)
Signed-off-by: Felix Cheung <[email protected]>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6cc6cb2a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6cc6cb2a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6cc6cb2a
Branch: refs/heads/branch-2.0
Commit: 6cc6cb2a95cbf5db7d1f7392a9e64e58af7ebc73
Parents: e8923d2
Author: Felix Cheung <[email protected]>
Authored: Thu Oct 20 21:12:55 2016 -0700
Committer: Felix Cheung <[email protected]>
Committed: Thu Oct 20 21:13:12 2016 -0700
----------------------------------------------------------------------
R/pkg/NAMESPACE | 2 +-
R/pkg/inst/tests/testthat/test_sparkSQL.R | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/6cc6cb2a/R/pkg/NAMESPACE
----------------------------------------------------------------------
diff --git a/R/pkg/NAMESPACE b/R/pkg/NAMESPACE
index 4c77d95..62c33a7 100644
--- a/R/pkg/NAMESPACE
+++ b/R/pkg/NAMESPACE
@@ -3,7 +3,7 @@
importFrom("methods", "setGeneric", "setMethod", "setOldClass")
importFrom("methods", "is", "new", "signature", "show")
importFrom("stats", "gaussian", "setNames")
-importFrom("utils", "download.file", "packageVersion", "untar")
+importFrom("utils", "download.file", "object.size", "packageVersion", "untar")
# Disable native libraries till we figure out how to package it
# See SPARKR-7839
http://git-wip-us.apache.org/repos/asf/spark/blob/6cc6cb2a/R/pkg/inst/tests/testthat/test_sparkSQL.R
----------------------------------------------------------------------
diff --git a/R/pkg/inst/tests/testthat/test_sparkSQL.R
b/R/pkg/inst/tests/testthat/test_sparkSQL.R
index c9eedd5..d33fcde 100644
--- a/R/pkg/inst/tests/testthat/test_sparkSQL.R
+++ b/R/pkg/inst/tests/testthat/test_sparkSQL.R
@@ -212,7 +212,7 @@ test_that("createDataFrame uses files for large objects", {
# To simulate a large file scenario, we set spark.r.maxAllocationLimit to a
smaller value
conf <- callJMethod(sparkSession, "conf")
callJMethod(conf, "set", "spark.r.maxAllocationLimit", "100")
- df <- createDataFrame(iris)
+ df <- suppressWarnings(createDataFrame(iris))
# Resetting the conf back to default value
callJMethod(conf, "set", "spark.r.maxAllocationLimit",
toString(.Machine$integer.max / 10))
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
