Repository: spark
Updated Branches:
  refs/heads/master 557938e28 -> 6d7c38330


[SPARK-23275][SQL] fix the thread leaking in hive/tests

## What changes were proposed in this pull request?

This is a follow up of https://github.com/apache/spark/pull/20441.

The two lines actually can trigger the hive metastore bug: 
https://issues.apache.org/jira/browse/HIVE-16844

The two configs are not in the default `ObjectStore` properties, so any run 
hive commands after these two lines will set the `propsChanged` flag in the 
`ObjectStore.setConf` and then cause thread leaks.

I don't think the two lines are very useful. They can be removed safely.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, 
manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)

Please review http://spark.apache.org/contributing.html before opening a pull 
request.

Author: Feng Liu <feng...@databricks.com>

Closes #20562 from liufengdb/fix-omm.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6d7c3833
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6d7c3833
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6d7c3833

Branch: refs/heads/master
Commit: 6d7c38330e68c7beb10f54eee8b4f607ee3c4136
Parents: 557938e
Author: Feng Liu <feng...@databricks.com>
Authored: Fri Feb 9 16:21:47 2018 -0800
Committer: gatorsmile <gatorsm...@gmail.com>
Committed: Fri Feb 9 16:21:47 2018 -0800

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala   | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/6d7c3833/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
----------------------------------------------------------------------
diff --git 
a/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala 
b/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
index 59708e7..1902893 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
@@ -530,8 +530,6 @@ private[hive] class TestHiveSparkSession(
       // For some reason, RESET does not reset the following variables...
       // https://issues.apache.org/jira/browse/HIVE-9004
       metadataHive.runSqlHive("set hive.table.parameters.default=")
-      metadataHive.runSqlHive("set datanucleus.cache.collections=true")
-      metadataHive.runSqlHive("set datanucleus.cache.collections.lazy=true")
       // Lots of tests fail if we do not change the partition whitelist from 
the default.
       metadataHive.runSqlHive("set 
hive.metastore.partition.name.whitelist.pattern=.*")
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to