Repository: spark Updated Branches: refs/heads/master 20b7c684c -> 6b1b10ca8
[DOC] Fix comment on SparkPlanGraphEdge ## What changes were proposed in this pull request? `fromId` is the child, and `toId` is the parent, see line 127 in `buildSparkPlanGraphNode` above. The edges in Spark UI also go from child to parent. ## How was this patch tested? Comment change only. Inspected code above. Inspected how the edges in Spark UI look like. Closes #22268 from juliuszsompolski/sparkplangraphedgedoc. Authored-by: Juliusz Sompolski <ju...@databricks.com> Signed-off-by: Xiao Li <gatorsm...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6b1b10ca Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6b1b10ca Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6b1b10ca Branch: refs/heads/master Commit: 6b1b10ca85f17fc8cd8acc9d6705bd14115ba6b4 Parents: 20b7c68 Author: Juliusz Sompolski <ju...@databricks.com> Authored: Wed Aug 29 12:55:44 2018 -0700 Committer: Xiao Li <gatorsm...@gmail.com> Committed: Wed Aug 29 12:55:44 2018 -0700 ---------------------------------------------------------------------- .../scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/6b1b10ca/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala ---------------------------------------------------------------------- diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala index 884f945..e57d080 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala @@ -202,7 +202,7 @@ private[ui] class SparkPlanGraphCluster( /** - * Represent an edge in the SparkPlan tree. `fromId` is the parent node id, and `toId` is the child + * Represent an edge in the SparkPlan tree. `fromId` is the child node id, and `toId` is the parent * node id. */ private[ui] case class SparkPlanGraphEdge(fromId: Long, toId: Long) { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
