Repository: spark
Updated Branches:
refs/heads/master 543577a1e -> 9b7679a97
[SPARK-26294][CORE] Delete Unnecessary If statement
## What changes were proposed in this pull request?
Delete unnecessary If statement, because it Impossible execution when
records less than or equal to zero.it is only execution when records begin zero.
...................
if (inMemSorter == null || inMemSorter.numRecords() <= 0) {
return 0L;
}
....................
if (inMemSorter.numRecords() > 0) {
.....................
}
## How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration tests,
manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a pull
request.
Closes #23247 from wangjiaochun/inMemSorter.
Authored-by: 10087686 <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/9b7679a9
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/9b7679a9
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/9b7679a9
Branch: refs/heads/master
Commit: 9b7679a97ed2622081390301af8735e62055492d
Parents: 543577a
Author: 10087686 <[email protected]>
Authored: Fri Dec 7 14:11:25 2018 -0600
Committer: Sean Owen <[email protected]>
Committed: Fri Dec 7 14:11:25 2018 -0600
----------------------------------------------------------------------
.../collection/unsafe/sort/UnsafeExternalSorter.java | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/9b7679a9/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
----------------------------------------------------------------------
diff --git
a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
index 5056652..af5a934 100644
---
a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
+++
b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
@@ -213,14 +213,12 @@ public final class UnsafeExternalSorter extends
MemoryConsumer {
spillWriters.size() > 1 ? " times" : " time");
ShuffleWriteMetrics writeMetrics = new ShuffleWriteMetrics();
- // We only write out contents of the inMemSorter if it is not empty.
- if (inMemSorter.numRecords() > 0) {
- final UnsafeSorterSpillWriter spillWriter =
- new UnsafeSorterSpillWriter(blockManager, fileBufferSizeBytes,
writeMetrics,
- inMemSorter.numRecords());
- spillWriters.add(spillWriter);
- spillIterator(inMemSorter.getSortedIterator(), spillWriter);
- }
+
+ final UnsafeSorterSpillWriter spillWriter =
+ new UnsafeSorterSpillWriter(blockManager, fileBufferSizeBytes,
writeMetrics,
+ inMemSorter.numRecords());
+ spillWriters.add(spillWriter);
+ spillIterator(inMemSorter.getSortedIterator(), spillWriter);
final long spillSize = freeMemory();
// Note that this is more-or-less going to be a multiple of the page size,
so wasted space in
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
