This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 1f692e5 [SPARK-27200][WEBUI][HISTORYSERVER] History Environment tab
must sort Configurations/Properties by default
1f692e5 is described below
commit 1f692e522cefed0fcc10096c5ca5ce77650636f3
Author: Ajith <[email protected]>
AuthorDate: Wed Mar 20 20:16:17 2019 +0900
[SPARK-27200][WEBUI][HISTORYSERVER] History Environment tab must sort
Configurations/Properties by default
Environment Page in SparkUI have all the configuration sorted by key. But
this is not the case in History server case, to keep UX same, we can have it
sorted in history server too
## What changes were proposed in this pull request?
On render of Env page the properties are sorted before creating page
## How was this patch tested?
Manually tested in UI
Closes #24143 from ajithme/historyenv.
Authored-by: Ajith <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
.../main/scala/org/apache/spark/ui/env/EnvironmentPage.scala | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
index cbb8b3c..cf0815b 100644
--- a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
@@ -39,15 +39,15 @@ private[ui] class EnvironmentPage(
"Scala Version" -> appEnv.runtime.scalaVersion)
val runtimeInformationTable = UIUtils.listingTable(
- propertyHeader, jvmRow, jvmInformation, fixedWidth = true)
+ propertyHeader, jvmRow, jvmInformation.toSeq.sorted, fixedWidth = true)
val sparkPropertiesTable = UIUtils.listingTable(propertyHeader,
propertyRow,
- Utils.redact(conf, appEnv.sparkProperties.toSeq), fixedWidth = true)
+ Utils.redact(conf, appEnv.sparkProperties.sorted), fixedWidth = true)
val hadoopPropertiesTable = UIUtils.listingTable(propertyHeader,
propertyRow,
- Utils.redact(conf, appEnv.hadoopProperties.toSeq), fixedWidth = true)
+ Utils.redact(conf, appEnv.hadoopProperties.sorted), fixedWidth = true)
val systemPropertiesTable = UIUtils.listingTable(
- propertyHeader, propertyRow, appEnv.systemProperties, fixedWidth = true)
+ propertyHeader, propertyRow, appEnv.systemProperties.sorted, fixedWidth
= true)
val classpathEntriesTable = UIUtils.listingTable(
- classPathHeaders, classPathRow, appEnv.classpathEntries, fixedWidth =
true)
+ classPathHeaders, classPathRow, appEnv.classpathEntries.sorted,
fixedWidth = true)
val content =
<span>
<span class="collapse-aggregated-runtimeInformation collapse-table"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
