This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new ef2d63b [SPARK-27201][WEBUI] Toggle full job description on click
ef2d63b is described below
commit ef2d63bfb1859232d166320896957c0543c059cc
Author: Gengliang Wang <[email protected]>
AuthorDate: Wed Mar 20 21:29:13 2019 +0900
[SPARK-27201][WEBUI] Toggle full job description on click
## What changes were proposed in this pull request?
Previously, in https://github.com/apache/spark/pull/6646 there was an
improvement to show full job description after double clicks.
I think this is a bit hard to be noticed by some users. I suggest changing
the event to one click.
Also, after the full description is shown, another click should be able to
hide the overflow text again.
Before click:
After click:
Click again:
## How was this patch tested?
Manually check.
Closes #24145 from gengliangwang/showDescriptionDetail.
Authored-by: Gengliang Wang <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
.../main/resources/org/apache/spark/ui/static/additional-metrics.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
index 3c8dddd..3798dc4 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
@@ -83,8 +83,8 @@ $(function() {
$(this).parent().find('input[type="checkbox"]').trigger('click');
});
- // Trigger a double click on the span to show full job description.
- $(".description-input").dblclick(function() {
-
$(this).removeClass("description-input").addClass("description-input-full");
+ // Show/hide full job description on click event.
+ $(".description-input").click(function() {
+ $(this).toggleClass("description-input-full");
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
