This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new bfa7f112 [SPARK-27869][CORE] Redact sensitive information in System 
Properties from UI
bfa7f112 is described below

commit bfa7f112e3258926befe9eaa9a489d3e0c4e2a0a
Author: Aaruna <aaruna.god...@gmail.com>
AuthorDate: Wed May 29 10:30:16 2019 -0700

    [SPARK-27869][CORE] Redact sensitive information in System Properties from 
UI
    
    ## What changes were proposed in this pull request?
    
    Currently system properties are not redacted. This PR fixes that, so that 
any credentials passed as System properties are redacted as well.
    
    ## How was this patch tested?
    
    Manual test. Run the following and see the UI.
    ```
    bin/spark-shell --conf 'spark.driver.extraJavaOptions=-DMYSECRET=app'
    ```
    
    Closes #24733 from aaruna/27869.
    
    Authored-by: Aaruna <aaruna.god...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala 
b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
index cf0815b..76537af 100644
--- a/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
@@ -44,8 +44,8 @@ private[ui] class EnvironmentPage(
       Utils.redact(conf, appEnv.sparkProperties.sorted), fixedWidth = true)
     val hadoopPropertiesTable = UIUtils.listingTable(propertyHeader, 
propertyRow,
       Utils.redact(conf, appEnv.hadoopProperties.sorted), fixedWidth = true)
-    val systemPropertiesTable = UIUtils.listingTable(
-      propertyHeader, propertyRow, appEnv.systemProperties.sorted, fixedWidth 
= true)
+    val systemPropertiesTable = UIUtils.listingTable(propertyHeader, 
propertyRow,
+      Utils.redact(conf, appEnv.systemProperties.sorted), fixedWidth = true)
     val classpathEntriesTable = UIUtils.listingTable(
       classPathHeaders, classPathRow, appEnv.classpathEntries.sorted, 
fixedWidth = true)
     val content =


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to