This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 86c4e43 [SPARK-31644][BUILD] Make Spark's guava version configurable from the command line 86c4e43 is described below commit 86c4e4352565cf271a96b650f533ed89a725322c Author: Steve Loughran <ste...@cloudera.com> AuthorDate: Tue May 5 12:17:24 2020 -0700 [SPARK-31644][BUILD] Make Spark's guava version configurable from the command line ### What changes were proposed in this pull request? This adds the maven property guava.version which can be used to control the guava version for a build. It does not change the current version. ### Why are the changes needed? All future Hadoop releases are going to be built with a later guava version, including Hadoop 3.1.4. This means to run the spark tests with that release you need to update the spark guava version. This patch lets whoever builds spark do this locally. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ran the hadoop-cloud module tests with the 3.1.4 RC0 ``` mvn -T 1 -Phadoop-3.2 -Dhadoop.version=3.1.4 -Psnapshots-and-staging -Phadoop-cloud,yarn,kinesis-asl test --pl hadoop-cloud ``` observed the linkage problem ``` java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V at org.apache.hadoop.conf.Configuration.set(Configuration.java:1357) ``` made the version configurable, retested with ``` -Phadoop-3.2 -Dhadoop.version=3.1.4 -Psnapshots-and-staging Dguava.version=27.0-jre ``` all good. Closes #28455 from steveloughran/SPARK-31644-guava-version. Authored-by: Steve Loughran <ste...@cloudera.com> Signed-off-by: Dongjoon Hyun <dongj...@apache.org> --- pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9c55630..7d4c3c4 100644 --- a/pom.xml +++ b/pom.xml @@ -178,6 +178,7 @@ <!-- org.apache.commons/commons-pool2/--> <commons-pool2.version>2.6.2</commons-pool2.version> <datanucleus-core.version>4.1.17</datanucleus-core.version> + <guava.version>14.0.1</guava.version> <janino.version>3.0.16</janino.version> <jersey.version>2.30</jersey.version> <joda.version>2.10.5</joda.version> @@ -444,7 +445,7 @@ <dependency> <groupId>com.google.guava</groupId> <artifactId>guava</artifactId> - <version>14.0.1</version> + <version>${guava.version}</version> <scope>provided</scope> </dependency> <dependency> --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org