dongjoon-hyun commented on a change in pull request #284:
URL: https://github.com/apache/spark-website/pull/284#discussion_r469616425
##########
File path: committers.md
##########
@@ -132,6 +132,27 @@ In particular, if you are working on an area of the
codebase you are unfamiliar
Git history for that code to see who reviewed patches before. You can do this
using
`git log --format=full <filename>`, by examining the "Commit" field to see who
committed each patch.
+<h3>When to commit/merge a pull request</h3>
+
+PRs shall not be merged during active, on-topic discussion unless they address
issues such as critical security fixes of a public vulnerability. Under
extenuating circumstances, PRs may be merged during active, off-topic
discussion and the discussion directed to a more appropriate venue. Time should
be given prior to merging for those involved with the conversation to explain
if they believe they are on-topic.
Review comment:
+1 for `often at least 72 hours`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
