This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 356fdc9  [SPARK-34007][BUILD] Downgrade scala-maven-plugin to 4.3.0
356fdc9 is described below

commit 356fdc9a7fc88fd07751c40b920043eaebeb0abf
Author: HyukjinKwon <[email protected]>
AuthorDate: Tue Jan 5 17:20:08 2021 +0900

    [SPARK-34007][BUILD] Downgrade scala-maven-plugin to 4.3.0
    
    ### What changes were proposed in this pull request?
    
    This PR is a partial revert of https://github.com/apache/spark/pull/30456 
by downgrading scala-maven-plugin from 4.4.0 to 4.3.0.
    
    Currently, when you run the docker release script 
(`./dev/create-release/do-release-docker.sh`), it fails to compile as below 
during incremental compilation with zinc for an unknown reason:
    
    ```
    [INFO] Compiling 21 Scala sources and 3 Java sources to 
/opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes
 ...
    [ERROR] ## Exception when compiling 24 sources to 
/opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes
    java.lang.SecurityException: class "javax.servlet.SessionCookieConfig"'s 
signer information does not match signer information of other classes in the 
same package
    java.lang.ClassLoader.checkCerts(ClassLoader.java:891)
    java.lang.ClassLoader.preDefineClass(ClassLoader.java:661)
    java.lang.ClassLoader.defineClass(ClassLoader.java:754)
    java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
    java.net.URLClassLoader.access$100(URLClassLoader.java:74)
    java.net.URLClassLoader$1.run(URLClassLoader.java:369)
    java.net.URLClassLoader$1.run(URLClassLoader.java:363)
    java.security.AccessController.doPrivileged(Native Method)
    java.net.URLClassLoader.findClass(URLClassLoader.java:362)
    java.lang.ClassLoader.loadClass(ClassLoader.java:418)
    java.lang.ClassLoader.loadClass(ClassLoader.java:351)
    java.lang.Class.getDeclaredMethods0(Native Method)
    java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
    java.lang.Class.privateGetPublicMethods(Class.java:2902)
    java.lang.Class.getMethods(Class.java:1615)
    sbt.internal.inc.ClassToAPI$.toDefinitions0(ClassToAPI.scala:170)
    sbt.internal.inc.ClassToAPI$.$anonfun$toDefinitions$1(ClassToAPI.scala:123)
    scala.collection.mutable.HashMap.getOrElseUpdate(HashMap.scala:86)
    sbt.internal.inc.ClassToAPI$.toDefinitions(ClassToAPI.scala:123)
    sbt.internal.inc.ClassToAPI$.$anonfun$process$1(ClassToAPI.scala:3
    ```
    
    This happens when it builds Spark with Hadoop 2. It doesn't reproduce when 
you build this alone. It should follow the sequence of build in the release 
script.
    
    This is fixed by downgrading. Looks like there is a regression in 
scala-maven-plugin somewhere between 4.4.0 and 4.3.0.
    
    ### Why are the changes needed?
    
    To unblock the release.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, dev-only.
    
    ### How was this patch tested?
    
    It can be tested as below:
    
    ```bash
    ./dev/create-release/do-release-docker.sh -d $WORKING_DIR
    ```
    
    Closes #31031 from HyukjinKwon/SPARK-34007.
    
    Authored-by: HyukjinKwon <[email protected]>
    Signed-off-by: HyukjinKwon <[email protected]>
---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 91ca039..1282d3c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2468,7 +2468,7 @@
         <plugin>
           <groupId>net.alchim31.maven</groupId>
           <artifactId>scala-maven-plugin</artifactId>
-          <version>4.4.0</version>
+          <version>4.3.0</version>
           <executions>
             <execution>
               <id>eclipse-add-source</id>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to