[spark] branch branch-3.1 updated: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order

[dongjoon]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.1 by this push:
     new ee472fa  [SPARK-32924][WEBUI] Make duration column in master UI sorted 
in the correct order
ee472fa is described below

commit ee472fa0569f7dd7bb649fc72b77642c4311dd11
Author: Baohe Zhang <baohe.zh...@verizonmedia.com>
AuthorDate: Thu Mar 4 15:37:33 2021 -0800

    [SPARK-32924][WEBUI] Make duration column in master UI sorted in the 
correct order
    
    ### What changes were proposed in this pull request?
    
    Make the "duration" column in standalone mode master UI sorted by numeric 
duration, hence the column can be sorted by the correct order.
    
    Before changes:
    
![image](https://user-images.githubusercontent.com/26694233/110025426-f5a49300-7cf4-11eb-86f0-2febade86be9.png)
    
    After changes:
    
![image](https://user-images.githubusercontent.com/26694233/110025604-33092080-7cf5-11eb-8b34-215688faf56d.png)
    
    ### Why are the changes needed?
    
    Fix a UI bug to make the sorting consistent across different pages.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Ran several apps with different durations and verified the duration column 
on the master page can be sorted correctly.
    
    Closes #31743 from baohe-zhang/SPARK-32924.
    
    Authored-by: Baohe Zhang <baohe.zh...@verizonmedia.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit 9ac5ee2e17ca491eabf2e6e7d33ce7cfb5a002a7)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala 
b/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala
index 9e1f753..1dda683 100644
--- a/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala
@@ -309,7 +309,9 @@ private[ui] class MasterPage(parent: MasterWebUI) extends 
WebUIPage("") {
       <td>{UIUtils.formatDate(app.submitDate)}</td>
       <td>{app.desc.user}</td>
       <td>{app.state.toString}</td>
-      <td>{UIUtils.formatDuration(app.duration)}</td>
+      <td sorttable_customkey={app.duration.toString}>
+        {UIUtils.formatDuration(app.duration)}
+      </td>
     </tr>
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org