attilapiros edited a comment on pull request #328:
URL: https://github.com/apache/spark-website/pull/328#issuecomment-802621565


   Sure I will :) I am just checking the inside of the `merge_pr.py` whether I 
can improve it.
   
   TL;DR
   As I have two factor authentication for github the https based remotes are 
deprecated for me I know this as I got a mail:
   
   ```
    You recently used a password to access the repository at 
apache/spark-website with git using git/2.21.1 (Apple Git-122.3).
   
   Basic authentication using a password to Git is deprecated and will soon no 
longer work. Visit 
https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/
 for more information around suggested workarounds and removal dates.
   
   Thanks,
   The GitHub Team
   ```
   
   Visiting the link you will found:
   > If you have two-factor authentication enabled for your account, you are 
already required to use token- or SSH-based authentication.
   
   On the other hand using SSH is not working in `merge_pr.py`:
   
   My remote:
   ```
   apache       g...@github.com:apache/spark-website.git (fetch)
   apache       g...@github.com:apache/spark-website.git (push)
   ```
   
   My error:
   ```
   Traceback (most recent call last):
     File "./merge_pr.py", line 287, in <module>
       main()
     File "./merge_pr.py", line 278, in main
       merge_pr(pr_num, target_ref, title, body, pr_repo_desc)
     File "./merge_pr.py", line 111, in merge_pr
       run_cmd("git fetch %s pull/%s/head:%s" % (PR_REMOTE_NAME, pr_num, 
pr_branch_name))
     File "./merge_pr.py", line 86, in run_cmd
       return subprocess.check_output(cmd.split(" ")).decode('utf-8')
     File 
"/Users/attilazsoltpiros/.pyenv/versions/3.8.1/lib/python3.8/subprocess.py", 
line 411, in check_output
       return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
     File 
"/Users/attilazsoltpiros/.pyenv/versions/3.8.1/lib/python3.8/subprocess.py", 
line 512, in run
       raise CalledProcessError(retcode, process.args,
   subprocess.CalledProcessError: Command '['git', 'fetch', 'apache-github', 
'pull/328/head:PR_TOOL_MERGE_PR_328']' returned non-zero exit status 128.
   ```
   
   So I will fix this first :) Stay tuned!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to