This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new b3d7ebb [SPARK-36450][SQL] Remove unused UnresolvedV2Relation
b3d7ebb is described below
commit b3d7ebb2df6f13ddbdc7381b331e6bc6035c0a25
Author: Terry Kim <[email protected]>
AuthorDate: Mon Aug 9 16:27:45 2021 +0800
[SPARK-36450][SQL] Remove unused UnresolvedV2Relation
### What changes were proposed in this pull request?
Now that all the commands that use `UnresolvedV2Relation` have been
migrated to use `UnresolvedTable` and `UnresolvedView` (e.g, #33200),
`UnresolvedV2Relation` can be removed.
### Why are the changes needed?
To remove unused code.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Removing dead code and no code coverage existed before.
Closes #33677 from imback82/remove_unresolvedv2relation.
Authored-by: Terry Kim <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
---
.../spark/sql/catalyst/analysis/Analyzer.scala | 3 ---
.../sql/catalyst/analysis/CheckAnalysis.scala | 7 -------
.../spark/sql/catalyst/analysis/unresolved.scala | 23 ----------------------
3 files changed, 33 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
index 92973dc..9ea1f7d 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
@@ -1080,9 +1080,6 @@ class Analyzer(override val catalogManager:
CatalogManager)
}.getOrElse(write)
case _ => write
}
-
- case u: UnresolvedV2Relation =>
- CatalogV2Util.loadRelation(u.catalog, u.tableName).getOrElse(u)
}
/**
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
index 043bf95..9dc5db8 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
@@ -133,13 +133,6 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
val tblName =
write.table.asInstanceOf[UnresolvedRelation].multipartIdentifier
write.table.failAnalysis(s"Table or view not found: ${tblName.quoted}")
- case u: UnresolvedV2Relation if isView(u.originalNameParts) =>
- u.failAnalysis(
- s"Invalid command: '${u.originalNameParts.quoted}' is a view not a
table.")
-
- case u: UnresolvedV2Relation =>
- u.failAnalysis(s"Table not found: ${u.originalNameParts.quoted}")
-
case command: V2PartitionCommand =>
command.table match {
case r @ ResolvedTable(_, _, table, _) => table match {
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
index 9f05367..8417203 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
@@ -25,7 +25,6 @@ import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan,
UnaryNode}
import org.apache.spark.sql.catalyst.trees.TreePattern._
import org.apache.spark.sql.catalyst.util._
-import org.apache.spark.sql.connector.catalog.{Identifier, TableCatalog}
import org.apache.spark.sql.errors.{QueryCompilationErrors,
QueryExecutionErrors}
import org.apache.spark.sql.types.{DataType, Metadata, StructType}
import org.apache.spark.sql.util.CaseInsensitiveStringMap
@@ -76,28 +75,6 @@ object UnresolvedRelation {
}
/**
- * A variant of [[UnresolvedRelation]] which can only be resolved to a v2
relation
- * (`DataSourceV2Relation`), not v1 relation or temp view.
- *
- * @param originalNameParts the original table identifier name parts before
catalog is resolved.
- * @param catalog The catalog which the table should be looked up from.
- * @param tableName The name of the table to look up.
- */
-case class UnresolvedV2Relation(
- originalNameParts: Seq[String],
- catalog: TableCatalog,
- tableName: Identifier)
- extends LeafNode with NamedRelation {
- import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-
- override def name: String = originalNameParts.quoted
-
- override def output: Seq[Attribute] = Nil
-
- override lazy val resolved = false
-}
-
-/**
* An inline table that has not been resolved yet. Once resolved, it is turned
by the analyzer into
* a [[org.apache.spark.sql.catalyst.plans.logical.LocalRelation]].
*
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
