This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 35e264a [SPARK-37533][FOLLOWUP] Remove useless code in Analyzer and
TryEvalSuite
35e264a is described below
commit 35e264adee9c48c7542f403cbea963e9bb8db60c
Author: Gengliang Wang <[email protected]>
AuthorDate: Thu Jan 20 10:57:38 2022 -0800
[SPARK-37533][FOLLOWUP] Remove useless code in Analyzer and TryEvalSuite
### What changes were proposed in this pull request?
Remove useless code in Analyzer and TryEvalSuite
### Why are the changes needed?
Code clean up and avoid confusion.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UT
Closes #35260 from gengliangwang/removeDeadCode.
Authored-by: Gengliang Wang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../spark/sql/catalyst/analysis/Analyzer.scala | 3 ---
.../sql/catalyst/expressions/TryEvalSuite.scala | 24 ----------------------
2 files changed, 27 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
index a6c6036..103a445 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
@@ -1879,9 +1879,6 @@ class Analyzer(override val catalogManager:
CatalogManager)
}}
}
- // Group by alias is not allowed in ANSI mode.
- private def allowGroupByAlias: Boolean = conf.groupByAliases &&
!conf.ansiEnabled
-
override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperatorsUpWithPruning(
// mayResolveAttrByAggregateExprs requires the TreePattern
UNRESOLVED_ATTRIBUTE.
_.containsAllPatterns(AGGREGATE, UNRESOLVED_ATTRIBUTE), ruleId) {
diff --git
a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TryEvalSuite.scala
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TryEvalSuite.scala
index 4633b63..9280775 100644
---
a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TryEvalSuite.scala
+++
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TryEvalSuite.scala
@@ -45,28 +45,4 @@ class TryEvalSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(input, expected)
}
}
-
- test("try_element_at: array") {
- val left = Literal(Array(1, 2, 3))
- Seq(
- (0, null),
- (1, 1),
- (4, null)
- ).foreach { case (index, expected) =>
- val input = TryEval(ElementAt(left, Literal(index), failOnError = false))
- checkEvaluation(input, expected)
- }
- }
-
- test("try_element_at: map") {
- val left = Literal.create(Map(1 -> 1))
- Seq(
- (0, null),
- (1, 1),
- (4, null)
- ).foreach { case (index, expected) =>
- val input = TryEval(ElementAt(left, Literal(index), failOnError = false))
- checkEvaluation(input, expected)
- }
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
