This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new 27f78e6672e [SPARK-39657][YARN] YARN AM client should call the
non-static setTokensConf method
27f78e6672e is described below
commit 27f78e6672e4ca5449539f88793fd6f76c8e1df2
Author: Chao Sun <[email protected]>
AuthorDate: Fri Jul 1 13:46:55 2022 -0700
[SPARK-39657][YARN] YARN AM client should call the non-static setTokensConf
method
### What changes were proposed in this pull request?
This fixes a bug in the original SPARK-37205 PR, where we treat the method
`setTokensConf` as a static method, but it should be non-static instead.
### Why are the changes needed?
The method `setTokensConf` is non-static so the current code will fail:
```
06/29/2022 - 17:28:16 - Exception in thread "main"
java.lang.IllegalArgumentException: object is not an instance of declaring class
06/29/2022 - 17:28:16 - at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
06/29/2022 - 17:28:16 - at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
06/29/2022 - 17:28:16 - at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
06/29/2022 - 17:28:16 - at
java.base/java.lang.reflect.Method.invoke(Method.java:566)
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually tested this change internally and it now works.
Closes #37050 from sunchao/SPARK-39657.
Authored-by: Chao Sun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 6624d91c9644526f1cb6fdfb4677604b40aa786f)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
index f364b792160..5402c503908 100644
---
a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
+++
b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
@@ -391,7 +391,7 @@ private[spark] class Client(
throw new SparkException(s"Cannot find setTokensConf method in
${amContainer.getClass}." +
s" Please check YARN version and make sure it is 2.9+ or 3.x")
}
- setTokensConfMethod.invoke(ByteBuffer.wrap(dob.getData))
+ setTokensConfMethod.invoke(amContainer, ByteBuffer.wrap(dob.getData))
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
