This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 71bc4ada95d [MINOR][TESTS] Remove mistakenly added style off for 
"assume"
71bc4ada95d is described below

commit 71bc4ada95d07a1a6ea320ea2a778f5f381ad287
Author: Jungtaek Lim <kabhwan.opensou...@gmail.com>
AuthorDate: Thu Oct 6 15:38:48 2022 +0900

    [MINOR][TESTS] Remove mistakenly added style off for "assume"
    
    ### What changes were proposed in this pull request?
    
    This PR removes the scalastyle off/on from two test recent suites which is 
not used by Apache Spark.
    
    ### Why are the changes needed?
    
    Some of test suites turn on and off for style rule which Apache Spark does 
not use.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    N/A
    
    Closes #38125 from HeartSaVioR/MINOR-remove-unnecessary-assume-style-off.
    
    Authored-by: Jungtaek Lim <kabhwan.opensou...@gmail.com>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 ...MapGroupsInPandasWithStateDistributionSuite.scala |  2 --
 .../FlatMapGroupsInPandasWithStateSuite.scala        | 20 --------------------
 2 files changed, 22 deletions(-)

diff --git 
a/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateDistributionSuite.scala
 
b/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateDistributionSuite.scala
index 985e45602a2..9c6573fd782 100644
--- 
a/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateDistributionSuite.scala
+++ 
b/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateDistributionSuite.scala
@@ -32,9 +32,7 @@ class FlatMapGroupsInPandasWithStateDistributionSuite extends 
StreamTest
 
   test("applyInPandasWithState should require StatefulOpClusteredDistribution 
" +
     "from children - without initial state") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain running count up to 2, and then remove the count
     // Returns the data and the count if state is defined, otherwise does not 
return anything
diff --git 
a/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateSuite.scala
 
b/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateSuite.scala
index 4d62ccd1423..785cbec9805 100644
--- 
a/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateSuite.scala
+++ 
b/sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsInPandasWithStateSuite.scala
@@ -34,9 +34,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   import testImplicits._
 
   test("applyInPandasWithState - streaming") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain running count up to 2, and then remove the count
     // Returns the data and the count if state is defined, otherwise does not 
return anything
@@ -116,9 +114,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
 
   test("applyInPandasWithState - streaming, multiple groups in partition, " +
     "multiple outputs per grouping key") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     val pythonScript =
       """
@@ -190,9 +186,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("applyInPandasWithState - streaming + aggregation") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain running count up to 2, and then remove the count
     // Returns the data and the count (-1 if count reached beyond 2 and state 
was just removed)
@@ -268,9 +262,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("applyInPandasWithState - streaming with processing time timeout") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain the count as state and set the proc. time timeout 
delay of 10 seconds.
     // It returns the count if changed, or -1 if the state was removed by 
timeout.
@@ -373,9 +365,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("applyInPandasWithState - streaming w/ event time timeout + watermark") 
{
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // timestamp_seconds assumes the base timezone is UTC. However, the 
provided function
     // localizes it. Therefore, this test assumes the timezone is in UTC
@@ -464,9 +454,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
 
   def testWithTimeout(timeoutConf: GroupStateTimeout): Unit = {
     test("SPARK-20714: watermark does not fail query when timeout = " + 
timeoutConf) {
-      // scalastyle:off assume
       assume(shouldTestPandasUDFs)
-      // scalastyle:on assume
 
       // timestamp_seconds assumes the base timezone is UTC. However, the 
provided function
       // localizes it. Therefore, this test assumes the timezone is in UTC
@@ -538,9 +526,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   testWithTimeout(ProcessingTimeTimeout)
 
   test("applyInPandasWithState - uses state format version 2 by default") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain running count up to 2, and then remove the count
     // Returns the data and the count if state is defined, otherwise does not 
return anything
@@ -613,9 +599,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("applyInPandasWithState - streaming - arrow RecordBatch size with 
chunking") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     val pythonScript =
       """
@@ -675,9 +659,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("applyInPandasWithState - streaming - partial consume of iterator in 
user function") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     val pythonScript =
       """
@@ -740,9 +722,7 @@ class FlatMapGroupsInPandasWithStateSuite extends 
StateStoreMetricsTest {
   }
 
   test("SPARK-40670: applyInPandasWithState - streaming having non-null 
columns") {
-    // scalastyle:off assume
     assume(shouldTestPandasUDFs)
-    // scalastyle:on assume
 
     // Function to maintain the count as state and set the proc. time timeout 
delay of 10 seconds.
     // It returns the count if changed, or -1 if the state was removed by 
timeout.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to