This is an automated email from the ASF dual-hosted git repository.
yikun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 52e5856 [SPARK-40864] Remove pip/setuptools dynamic upgrade
52e5856 is described below
commit 52e5856d81e70a9d9e87292c6caf42587ce433df
Author: Yikun Jiang <[email protected]>
AuthorDate: Fri Oct 21 17:02:54 2022 +0800
[SPARK-40864] Remove pip/setuptools dynamic upgrade
### What changes were proposed in this pull request?
Remove pip/setuptools dynamic upgrade in dockerfile
### Why are the changes needed?
According to [official image
suggestion](https://github.com/docker-library/official-images#repeatability),
`Rebuilding the same Dockerfile should result in the same version of the image
being packaged`.
But we used to upgrade pip/setuptools to latest, actually we don't need a
latest pip/setuptools for any reason I can think out. I also take a look on
[initial
commits](https://github.com/apache-spark-on-k8s/spark/commit/befcf0a30651d0335bb57c242a824e43748db33f)
for this line, according merge history no more reason for it.
### Does this PR introduce _any_ user-facing change?
The OS recommand pip/setuptools version is used.
### How was this patch tested?
CI passed.
Closes #17 from Yikun/remove-pip.
Authored-by: Yikun Jiang <[email protected]>
Signed-off-by: Yikun Jiang <[email protected]>
---
3.3.0/scala2.12-java11-python3-r-ubuntu/Dockerfile | 1 -
3.3.0/scala2.12-java11-python3-ubuntu/Dockerfile | 1 -
Dockerfile.template | 1 -
3 files changed, 3 deletions(-)
diff --git a/3.3.0/scala2.12-java11-python3-r-ubuntu/Dockerfile
b/3.3.0/scala2.12-java11-python3-r-ubuntu/Dockerfile
index ac16bdd..8c2761e 100644
--- a/3.3.0/scala2.12-java11-python3-r-ubuntu/Dockerfile
+++ b/3.3.0/scala2.12-java11-python3-r-ubuntu/Dockerfile
@@ -26,7 +26,6 @@ RUN set -ex && \
ln -s /lib /lib64 && \
apt install -y gnupg2 wget bash tini libc6 libpam-modules krb5-user
libnss3 procps net-tools gosu && \
apt install -y python3 python3-pip && \
- pip3 install --upgrade pip setuptools && \
apt install -y r-base r-base-dev && \
mkdir -p /opt/spark && \
mkdir /opt/spark/python && \
diff --git a/3.3.0/scala2.12-java11-python3-ubuntu/Dockerfile
b/3.3.0/scala2.12-java11-python3-ubuntu/Dockerfile
index c6e433d..6a0017a 100644
--- a/3.3.0/scala2.12-java11-python3-ubuntu/Dockerfile
+++ b/3.3.0/scala2.12-java11-python3-ubuntu/Dockerfile
@@ -26,7 +26,6 @@ RUN set -ex && \
ln -s /lib /lib64 && \
apt install -y gnupg2 wget bash tini libc6 libpam-modules krb5-user
libnss3 procps net-tools gosu && \
apt install -y python3 python3-pip && \
- pip3 install --upgrade pip setuptools && \
mkdir -p /opt/spark && \
mkdir /opt/spark/python && \
mkdir -p /opt/spark/examples && \
diff --git a/Dockerfile.template b/Dockerfile.template
index 2b90fe5..a220247 100644
--- a/Dockerfile.template
+++ b/Dockerfile.template
@@ -27,7 +27,6 @@ RUN set -ex && \
apt install -y gnupg2 wget bash tini libc6 libpam-modules krb5-user
libnss3 procps net-tools gosu && \
{%- if HAVE_PY %}
apt install -y python3 python3-pip && \
- pip3 install --upgrade pip setuptools && \
{%- endif %}
{%- if HAVE_R %}
apt install -y r-base r-base-dev && \
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
