This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 91fda184479 [SPARK-41872][CONNECT][PYTHON][TESTS] Enable tests 
`test_fillna` and `test_replace`
91fda184479 is described below

commit 91fda1844790fd4b5b918e3fbfd09a304a8104e5
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Tue Jan 10 17:57:21 2023 +0900

    [SPARK-41872][CONNECT][PYTHON][TESTS] Enable tests `test_fillna` and 
`test_replace`
    
    ### What changes were proposed in this pull request?
    Enable `test_fillna` and `test_replace`
    
    ### Why are the changes needed?
    test coverage
    
    ### Does this PR introduce _any_ user-facing change?
    no
    
    ### How was this patch tested?
    enabled tests
    
    Closes #39477 from zhengruifeng/connect_fix_41872.
    
    Authored-by: Ruifeng Zheng <ruife...@apache.org>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 python/pyspark/sql/tests/connect/test_parity_dataframe.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/python/pyspark/sql/tests/connect/test_parity_dataframe.py 
b/python/pyspark/sql/tests/connect/test_parity_dataframe.py
index ed7c85d32ab..84f3dceb43f 100644
--- a/python/pyspark/sql/tests/connect/test_parity_dataframe.py
+++ b/python/pyspark/sql/tests/connect/test_parity_dataframe.py
@@ -62,11 +62,6 @@ class DataFrameParityTests(DataFrameTestsMixin, 
ReusedConnectTestCase):
     def test_extended_hint_types(self):
         super().test_extended_hint_types()
 
-    # TODO(SPARK-41872): Fix DataFrame createDataframe handling of None
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_fillna(self):
-        super().test_fillna()
-
     # TODO: comparing types, need to expose connect types
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_generic_hints(self):
@@ -105,11 +100,6 @@ class DataFrameParityTests(DataFrameTestsMixin, 
ReusedConnectTestCase):
     def test_repartitionByRange_dataframe(self):
         super().test_repartitionByRange_dataframe()
 
-    # TODO(SPARK-41872): Fix DataFrame createDataframe handling of None
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_replace(self):
-        super().test_replace()
-
     # TODO(SPARK-41834): Implement SparkSession.conf
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_repr_behaviors(self):


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to