This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new b054d49eef6 [MINOR][CORE][TESTS] Suppress unchecked warnings in
OneForOneStreamManagerSuite
b054d49eef6 is described below
commit b054d49eef62402741082a99c2394d467fb8ce14
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Sun Jan 15 21:13:40 2023 -0800
[MINOR][CORE][TESTS] Suppress unchecked warnings in
OneForOneStreamManagerSuite
### What changes were proposed in this pull request?
This PR aims to suppress the two test code compilation warnings in
`network-common` module.
```
[warn]
/Users/dongjoon/APACHE/spark-merge/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java:105:1:
[unchecked] unchecked conversion
[warn] Iterator<ManagedBuffer> buffers = Mockito.mock(Iterator.class);
[warn] ^ required:
Iterator<ManagedBuffer>
[warn] found: Iterator
[warn]
/Users/dongjoon/APACHE/spark-merge/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java:111:1:
[unchecked] unchecked conversion
[warn] Iterator<ManagedBuffer> buffers2 = Mockito.mock(Iterator.class);
[warn] ^ required:
Iterator<ManagedBuffer>
[warn] found: Iterator
```
### Why are the changes needed?
To suppress warnings in `network-common` directory.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually check the output with the following.
```
$ build/sbt "network-common/test"
```
Closes #39589 from dongjoon-hyun/unchecked.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../org/apache/spark/network/server/OneForOneStreamManagerSuite.java | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java
b/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java
index 54f261705df..3e4ac99cb96 100644
---
a/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java
+++
b/common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java
@@ -98,6 +98,7 @@ public class OneForOneStreamManagerSuite {
Assert.assertEquals(0, manager.numStreamStates());
}
+ @SuppressWarnings("unchecked")
@Test
public void
streamStatesAreFreedWhenConnectionIsClosedEvenIfBufferIteratorThrowsException()
{
OneForOneStreamManager manager = new OneForOneStreamManager();
@@ -127,6 +128,7 @@ public class OneForOneStreamManagerSuite {
Assert.assertEquals(0, manager.numStreamStates());
}
+ @SuppressWarnings("unchecked")
@Test
public void streamStatesAreFreeOrNotWhenConnectionIsClosed() {
OneForOneStreamManager manager = new OneForOneStreamManager();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
