This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch branch-3.5 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push: new 04e0d85e8a3 [SPARK-44422][FOLLOWUP][CONNECT] Fix typo in ProtoUtils 04e0d85e8a3 is described below commit 04e0d85e8a3ed683a4ff851cf823980290e49b5e Author: Juliusz Sompolski <ju...@databricks.com> AuthorDate: Sat Aug 12 08:50:57 2023 +0900 [SPARK-44422][FOLLOWUP][CONNECT] Fix typo in ProtoUtils ### What changes were proposed in this pull request? Fix typo - the constant should be a val, not var. Triggered a style warning for me that got turned into error in my dev environment: ``` [error] vendor/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala:87:15 [error] private var SPARK_JOB_TAGS_SEP in object ProtoUtils is never updated: consider using immutable val [error] private var SPARK_JOB_TAGS_SEP = ',' // SparkContext.SPARK_JOB_TAGS_SEP [error] ^ [error] one error found ``` ### Why are the changes needed? Typo in previous work. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI Closes #42456 from juliuszsompolski/protoutils-typo. Authored-by: Juliusz Sompolski <ju...@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> (cherry picked from commit 3ed99206cc2a387bbfedcafaeee5e8a62cdc3f99) Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- .../src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala b/connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala index 99684eef7d7..efbdb6ac19f 100644 --- a/connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala +++ b/connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/ProtoUtils.scala @@ -84,7 +84,7 @@ private[connect] object ProtoUtils { // Because Spark Connect operation tags are also set as SparkContext Job tags, they cannot contain // SparkContext.SPARK_JOB_TAGS_SEP - private var SPARK_JOB_TAGS_SEP = ',' // SparkContext.SPARK_JOB_TAGS_SEP + private val SPARK_JOB_TAGS_SEP = ',' // SparkContext.SPARK_JOB_TAGS_SEP /** * Validate if a tag for ExecutePlanRequest.tags is valid. Throw IllegalArgumentException if --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org