This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c783e5abb58 [SPARK-44990][SQL][FOLLOWUP] Remove lazy of
`nullAsQuotedEmptyString`
c783e5abb58 is described below
commit c783e5abb58a04e1151ded7553dfe6ebdcc0c15e
Author: Jia Fan <[email protected]>
AuthorDate: Fri Sep 1 09:25:02 2023 +0800
[SPARK-44990][SQL][FOLLOWUP] Remove lazy of `nullAsQuotedEmptyString`
### What changes were proposed in this pull request?
This is a follow up PR of #42738 . Remove lazy of `nullAsQuotedEmptyString`.
### Why are the changes needed?
Remove lazy of nullAsQuotedEmptyString. Because most case it useless.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
add new test.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #42744 from Hisoka-X/SPARK-44990_csv_null_benchmark.
Authored-by: Jia Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
---
.../scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
index c8eded3ccd4..0ed89f8cba2 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
@@ -60,7 +60,7 @@ class UnivocityGenerator(
options.locale,
legacyFormat = FAST_DATE_FORMAT,
isParsing = false)
- private lazy val nullAsQuotedEmptyString =
+ private val nullAsQuotedEmptyString =
SQLConf.get.getConf(SQLConf.LEGACY_NULL_VALUE_WRITTEN_AS_QUOTED_EMPTY_STRING_CSV)
@scala.annotation.tailrec
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]